Conversation
jaypipes
reviewed
Mar 9, 2026
jaypipes
left a comment
There was a problem hiding this comment.
@Shivs11 it's a little confusing to have the main image build and release process handled by goreleaser (via the workflows/publish-main-image.yml workflow file) and then have this new workflow manually use QEMU and docker buildx to build/publish images. Is there not a way to use goreleaser and have the build/publish workflows for both main and release branch images be the same?
Replace publish-main-image.yml and publish-branch-image.yml with a unified publish-image.yml that handles both push-to-main and manual branch image builds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
carlydf
reviewed
Mar 10, 2026
carlydf
approved these changes
Mar 10, 2026
Shivs11
added a commit
that referenced
this pull request
Mar 10, 2026
- add a manual GitHub Actions workflow to publish controller images from the current HEAD of a specified branch - document the workflow briefly in the development section of the README - I think this is important and a nice to have in this repo. As the number of contributions grow, I would love to have a way to test un-merged controller PR's against internal pipelines to validate if the changes are backwards compat or not. - make lint-actions --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing