Skip to content

Mark it as an error if there are more then 2 issues #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evgeni merged 1 commit into from
Feb 11, 2026
Merged

Mark it as an error if there are more then 2 issues #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion prprocessor/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
COMMIT_ISSUES_REGEX = re.compile(r'#(\d+)')
CHECK_NAME = 'Redmine issues'
WHITELISTED_ORGANIZATIONS = ('theforeman', 'Katello')
MAX_ISSUES = 2


class Label(Enum):
Expand Down Expand Up @@ -252,7 +253,10 @@ async def run_pull_request_check(pull_request: Mapping, check_run=None) -> bool:
}
else:
try:
await update_redmine_on_issues(pull_request, issue_results.valid_issues)
if len(issue_results.valid_issues) <= MAX_ISSUES:
await update_redmine_on_issues(pull_request, issue_results.valid_issues)
else:
logger.warn(f'Not updating Redmine as the PR references more than {MAX_ISSUES} issues.')
except: # pylint: disable=bare-except
logger.exception('Failed to update Redmine issues')

Expand All @@ -261,6 +265,7 @@ async def run_pull_request_check(pull_request: Mapping, check_run=None) -> bool:
'Invalid project': format_redmine_issues(issue_results.invalid_project_issues),
'Issues not found in redmine': issue_results.missing_issue_ids,
'Valid issues': format_redmine_issues(issue_results.valid_issues),
'Too many issues': format_redmine_issues(issue_results.valid_issues) if len(issue_results.valid_issues) > MAX_ISSUES else [],
}

non_empty = [title for title, lines in summary.items() if lines]
Expand Down