ASoC: SOF: Intel: hda-stream: clear hstream->running flag in hw_params#5681
Open
ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
Open
ASoC: SOF: Intel: hda-stream: clear hstream->running flag in hw_params#5681ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
Conversation
During hw_params call we make sure that the host DMA is stopped but the hstream->running flag is not explicitly cleared at the same time. If the host DMA fails to stop during previous use then the flag is left set and on next start the host DMA will be left disabled since the trigger:STOP will skip the DMA enable. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Collaborator
|
@ujfalusi I did a quick test and this didn't solve the SRC 11.025fail->48fail->48success case. I still need two attempts to get 48k working even with this PR included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During hw_params call we make sure that the host DMA is stopped but the hstream->running flag is not explicitly cleared at the same time.
If the host DMA fails to stop during previous use then the flag is left set and on next start the host DMA will be left disabled since the trigger:STOP will skip the DMA enable.