Offer createKey() to register a new API key.#9
Open
rolftimmermans wants to merge 25 commits intomasterfrom
Open
Offer createKey() to register a new API key.#9rolftimmermans wants to merge 25 commits intomasterfrom
rolftimmermans wants to merge 25 commits intomasterfrom
Conversation
|
Mm.....This commits are too long to read. It should squash them to the less commits when merging this PR. |
…compression count, paying state and email address when they are returned from validate() calls.
peter279k
reviewed
Nov 7, 2018
| self::$client = NULL; | ||
| } | ||
|
|
||
| public static function getKey() { |
There was a problem hiding this comment.
I think it should use PHP_CodeSniffer or php-cs-fixer to fix PSR-2 coding style.
peter279k
reviewed
Nov 7, 2018
| function emailAddress() { | ||
| return Tinify::getEmailAddress(); | ||
| } | ||
|
|
There was a problem hiding this comment.
These methods are very strange.
They looks similar. The duplicate should be removed.
… returned from the /keys endpoint.
|
Would love to see this in production! I got two quick questions:
|
|
Hi there! Once we have implemented the same logic for the other libraries we will put this into production and update the documentation.
|
Rebase master on create-key branch
…ixes * Set minimum TLS version to v1.2 * Update changelog * Php 8.5 Support (#42) * Avoid depreciation notice in PHP 8.5 * Add PHP 8.5 to tests * Remove dynamic property depreciation notice * Anticipate V1.6.4 * Use HTTP Post when retrieving result (#41) * Use http post when retrieving result * 1.6.4 and changelog * When commands is empty, do a get with body null * Change condition to use empty * fix: correct HTTP method logic for Source result requests - Fix inverted boolean logic for has_commands check - Ensure GET is used when no commands are present - Ensure POST is used when commands are present - Add comprehensive tests for both GET and POST scenarios * docs(changelog): add missing changes to `1.6.4` * fix(client): explicitly unset connection handler to free connection when PHP>8.5 * Trigger build * Trigger build * Trigger build --------- Co-authored-by: Remco Koopmans <me@remcokoopmans.com> Co-authored-by: Bruce Wells <brucekwells@gmail.com> Co-authored-by: Jovan Marić <jovan@maric.vision>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.