Fixes mapping for Traversable objects in IterableExtractor.#23
Merged
gustavofreze merged 1 commit intomainfrom Feb 10, 2026
Merged
Fixes mapping for Traversable objects in IterableExtractor.#23gustavofreze merged 1 commit intomainfrom
gustavofreze merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes iterable mapping when an IterableMapper object is itself Traversable (e.g., implements IteratorAggregate), ensuring mapping uses the object’s iterator (and its keys) rather than reflecting and mapping an internal iterable property.
Changes:
- Update
IterableExtractorto directly convertTraversableobjects viaiterator_to_array($object). - Add test coverage for mapping a
Traversablecollection that yields keyed items. - Introduce new test model fixtures (
Invoice,Invoices,InvoiceSummaries) to reproduce and validate the keyed-iterator scenario.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Internal/Extractors/IterableExtractor.php |
Ensures Traversable iterable mappers are extracted via iteration (preserving yielded keys). |
tests/CollectionMappingTest.php |
Adds a regression test asserting keys from a traversable iterator are preserved in mapped output. |
tests/Models/Invoice.php |
Test fixture representing an invoice element to be mapped. |
tests/Models/Invoices.php |
Test fixture iterable collection used by the traversable mapping test. |
tests/Models/InvoiceSummaries.php |
Test fixture implementing IteratorAggregate and yielding invoices keyed by invoice id. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.