Use setup-tenv action; detect version by default#16
Open
OJFord wants to merge 3 commits intotofuutils:mainfrom
Open
Use setup-tenv action; detect version by default#16OJFord wants to merge 3 commits intotofuutils:mainfrom
OJFord wants to merge 3 commits intotofuutils:mainfrom
Conversation
Fixes tofuutils#10. Fixes tofuutils#14. Signed-off-by: Oliver Ford <dev@ojford.com>
It doesn't make sense to prefer `latest` to `latest-allowed`, if they're not identical then the former is broken and the latter works. Signed-off-by: Oliver Ford <dev@ojford.com>
There was a problem hiding this comment.
Pull request overview
This PR migrates the tenv-github-action from a Docker-based action to a composite action that uses the setup-tenv action. It also changes the default behavior to detect the appropriate version from the project configuration instead of defaulting to "latest".
Changes:
- Migrates from Docker container action to composite action using setup-tenv
- Removes default "latest" version, allowing version detection from project files
- Adds conditional logic to either install a specific version or detect and install the appropriate version
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| action.yml | Converted from Docker to composite action; removed default version; added conditional install/detect logic |
| Dockerfile | Removed as Docker-based execution is no longer needed |
| src/tenv-action.sh | Removed as bash script is replaced by inline composite action steps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
OJFord
commented
Jan 14, 2026
| image: "Dockerfile" | ||
| using: "composite" | ||
| steps: | ||
| - uses: OJFord/setup-tenv@issues/16 |
Author
There was a problem hiding this comment.
Don't trust me with that(!) - I'll revert to tofuutils/setup-tenv@main (it doesn't have releases) once tofuutils/setup-tenv#17 is in (or tofuutils/setup-tenv#16 resolved some way).
Partly to work around tofuutils/tenv/#534 in some cases, but convenient generally. Signed-off-by: Oliver Ford <dev@ojford.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install tenv via tofuutils/setup-tenv
Fixes #10.
Fixes #14.
Use safer default of latest-allowed
It doesn't make sense to prefer
latesttolatest-allowed, if they'renot identical then the former is broken and the latter works.
Detect version if not given
Partly to work around tofuutils/tenv/#534 in some cases, but convenient
generally.