Skip to content

Comments

fix: schedules, restore direct update semantics and strengthen parsin…#205

Open
burakdede wants to merge 1 commit intotower:developfrom
burakdede:fix/issue-167-schedule-validation
Open

fix: schedules, restore direct update semantics and strengthen parsin…#205
burakdede wants to merge 1 commit intotower:developfrom
burakdede:fix/issue-167-schedule-validation

Conversation

@burakdede
Copy link
Contributor

…g tests

This PR fixes the schedule update CLI behavior reported with #167

schedules update argument parsing was semantically wrong due to allow_external_subcommands, so the schedule ID/flags could be parsed unreliably.

  • Made schedule_id an explicit required positional arg for update and delete in clap.
  • Removed the external-subcommand parsing path.
  • Kept direct PUT /schedules/{id_or_name} update behavior with parsed CLI fields.
  • Added regression tests to lock parsing behavior and parameter handling.

Possible backend issues still persisting;

  1. Missing cron semantic validation on update. Backend accepted and persisted not-a-cron for PUT /schedules/{id}.
  2. Potential missing cron validation on create as well. Needs explicit confirmation that create and update enforce the same cron rules.
  3. Schedule ID existence is validated, but cron correctness is not, leading to partial/inconsistent contract behavior. I didn't want to introduce client side validation, I believe this is backend-first responsibility.
image

@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant