Conversation
…dation (#2273) - Implemented in-memory rate limiting for authentication requests to mitigate brute force attacks, with stricter limits for sensitive endpoints. - Added redirect URL validation to prevent open redirects, allowing only specified hosts. - Improved logging for rate limit exceedances during development. - Cleaned up old rate limit entries periodically to optimize memory usage. - Updated the OTP form to remove unnecessary API_URL declaration. Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
* feat(auth): enhance security with rate limiting and redirect URL validation - Implemented in-memory rate limiting for authentication requests to mitigate brute force attacks, with stricter limits for sensitive endpoints. - Added redirect URL validation to prevent open redirects, allowing only specified hosts. - Improved logging for rate limit exceedances during development. - Cleaned up old rate limit entries periodically to optimize memory usage. - Updated the OTP form to remove unnecessary API_URL declaration. * refactor(auth): update environment variable usage for base URL - Changed references from AUTH_BASE_URL and BETTER_AUTH_URL to BASE_URL for consistency in cookie domain handling. - Updated comments to clarify the purpose of BASE_URL in relation to OAuth callbacks and cookie domains.
* feat(auth): enhance security with rate limiting and redirect URL validation - Implemented in-memory rate limiting for authentication requests to mitigate brute force attacks, with stricter limits for sensitive endpoints. - Added redirect URL validation to prevent open redirects, allowing only specified hosts. - Improved logging for rate limit exceedances during development. - Cleaned up old rate limit entries periodically to optimize memory usage. - Updated the OTP form to remove unnecessary API_URL declaration. * refactor(auth): update environment variable usage for base URL - Changed references from AUTH_BASE_URL and BETTER_AUTH_URL to BASE_URL for consistency in cookie domain handling. - Updated comments to clarify the purpose of BASE_URL in relation to OAuth callbacks and cookie domains. * refactor(auth): update base URL configuration for auth client - Changed baseURL in authClient to use NEXT_PUBLIC_API_URL or default to 'http://localhost:3333' for improved environment configuration. - This change enhances flexibility for different deployment environments.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
* feat(integration): enhance connection handling with organization validation - Updated ChecksController and ConnectionsController to include organization ID in relevant endpoints, ensuring that connections are validated against the correct organization. - Introduced getConnectionForOrg method in ConnectionService to streamline organization-specific connection retrieval. - Enhanced VariablesController and QuestionnaireController to incorporate organization ID handling for connection variables and questionnaire responses. - Updated tests to cover new organization validation logic across affected controllers and services. * refactor(auth): standardize BASE_URL usage and remove deprecated auth proxy routes - Updated auth server configuration to consistently use BASE_URL for OAuth callbacks and cookie domain handling. - Removed references to AUTH_BASE_URL and BETTER_AUTH_URL, simplifying environment variable usage. - Deleted obsolete auth proxy routes from the app and portal, streamlining the authentication flow. - Enhanced comments and documentation to clarify the purpose of BASE_URL in relation to security and session management. --------- Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
* feat(integration): enhance connection handling with organization validation - Updated ChecksController and ConnectionsController to include organization ID in relevant endpoints, ensuring that connections are validated against the correct organization. - Introduced getConnectionForOrg method in ConnectionService to streamline organization-specific connection retrieval. - Enhanced VariablesController and QuestionnaireController to incorporate organization ID handling for connection variables and questionnaire responses. - Updated tests to cover new organization validation logic across affected controllers and services. * refactor(auth): standardize BASE_URL usage and remove deprecated auth proxy routes - Updated auth server configuration to consistently use BASE_URL for OAuth callbacks and cookie domain handling. - Removed references to AUTH_BASE_URL and BETTER_AUTH_URL, simplifying environment variable usage. - Deleted obsolete auth proxy routes from the app and portal, streamlining the authentication flow. - Enhanced comments and documentation to clarify the purpose of BASE_URL in relation to security and session management. * fix(auth): enhance body parsing for authentication routes - Implemented custom middleware in main.ts to skip body parsing for /api/auth routes, ensuring better-auth can read the raw request stream for OAuth flows. - Updated auth.module.ts to disable the module's body parser to prevent conflicts with the custom middleware. - Configured auth.server.ts to skip the state cookie CSRF check for OAuth flows, improving compatibility with cross-origin setups.
Contributor
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.