Allow sending headers with empty values#225
Open
gonubana wants to merge 1 commit intotyphoeus:masterfrom
Open
Conversation
while also allowing the user to remove default headers set by libcurl. See https://curl.se/libcurl/c/CURLOPT_HTTPHEADER.html for more details. passing " headers: {'h1' => 'v1', 'h2' => '', 'h3;' => ''} " corresponds to these curl options: " -H 'h1: v1' -H 'h2:' -H 'h3;' " Enhances typhoeus#132 Fixes typhoeus/typhoeus#706
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow sending headers with empty values,
while also allowing the user to remove default headers set by libcurl.
See https://curl.se/libcurl/c/CURLOPT_HTTPHEADER.html for more details.
Passing
headers: {'h1' => 'v1', 'h2' => '', 'h3;' => ''}corresponds to these curl options:
-H 'h1: v1' -H 'h2:' -H 'h3;'Enhances #132
Fixes typhoeus/typhoeus#706