Add option to pass a custom screenshotController#333
Open
TarekMedhat wants to merge 1 commit intoueman:masterfrom
Open
Add option to pass a custom screenshotController#333TarekMedhat wants to merge 1 commit intoueman:masterfrom
screenshotController#333TarekMedhat wants to merge 1 commit intoueman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add the option to pass a custom ScreenshotController
💡 Motivation and Context
I had a use case that required custom capture logic, which let me add native screenshot support for platform views by capturing the view natively.
💚 How did you test it?
Implemented a custom ScreenshotController and passed it to BetterFeedback widget.
📝 Checklist
🔮 Next steps
🔁 : Alternative Solution:
Another possible solution: is to only make the ScreenshotController key public and static without any further changes.
static final GlobalKey containerKey = GlobalKey();This works since the feedback widget wraps the app, so there will always be one scrollController all the time.
Then
feedbackBuildercan be used to override the onSubmit logic.