Open
Conversation
|
🍅 Пройдено тестов 8 из 9 |
|
🍅 Пройдено тестов 8 из 9 |
|
🍅 Пройдено тестов 8 из 9 |
|
🍅 Пройдено тестов 8 из 9 |
|
🍏 Пройдено тестов 9 из 9 |
onufrienko
reviewed
Nov 11, 2016
| console.info(event); | ||
| var emitEvent = []; | ||
| var splitEvent = event.split('.'); | ||
| var flag = 1; |
There was a problem hiding this comment.
Непонятно из названия, для чего конкретно этот флаг.
onufrienko
reviewed
Nov 11, 2016
| */ | ||
| off: function (event, context) { | ||
| console.info(event, context); | ||
| if (typeof (event) === 'string' && typeof (context) === 'object') { |
There was a problem hiding this comment.
Почему ты делаешь проверку именно так?
Что будет, если context будет объектом, но не валидным?
onufrienko
reviewed
Nov 11, 2016
| console.info(event, context); | ||
| if (typeof (event) === 'string' && typeof (context) === 'object') { | ||
| students = students.filter(function (subscriber) { | ||
|
|
onufrienko
reviewed
Nov 11, 2016
| var splitEvent = event.split('.'); | ||
| var flag = 1; | ||
|
|
||
| for (var i = 0; i < splitEvent.length; i++) { |
There was a problem hiding this comment.
Может, стоит попробовать переписать этот блок поаккуратнее? Я сходу не могу понять, что у тебя тут происходит
|
🍅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.