Conversation
|
@joaomnuno is attempting to deploy a commit to the kmkoushik's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe pull request adds an explicit GitHub OAuth issuer constant ( 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/web/src/server/auth.unit.test.ts`:
- Around line 39-44: The mocked env in the vi.mock call currently sets GITHUB_ID
and GITHUB_SECRET but misses the cloud-mode flag; update the mocked env object
inside vi.mock("~/env", ...) to include NEXT_PUBLIC_IS_CLOUD: true so tests run
with cloud-mode semantics (modify the env object literal used in the test file's
vi.mock).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3efc3fcf-c0c4-48d5-9741-954744114b79
📒 Files selected for processing (2)
apps/web/src/server/auth.tsapps/web/src/server/auth.unit.test.ts
Problem
GitHub OAuth sign-in fails during the callback stage with:
GitHub now includes an
issparameter in OAuth callback responses as part of RFC 9207. In NextAuth v4-style flows, the callback path validates that issuer when it is present. If the GitHub provider is configured without an explicit issuer, the callback throws before login can complete.Root Cause
UseSend relies on the built-in GitHub provider defaults in
next-auth@4.24.11. That appears to have been sufficient before GitHub started returningissin callback requests. Onceissis present, the callback path expects the provider config to declare the matching issuer metadata.This is the same failure mode reported in Langfuse issue #13091.
Fix
https://github.com/login/oauthTesting
References
Summary by cubic
Fixes GitHub OAuth sign-in failures by setting the GitHub provider
issuertohttps://github.com/login/oauthinnext-auth. Restores successful callbacks now that GitHub includesiss.issueron the GitHub provider to satisfyissvalidation during OAuth callbacks.issuer; mockNEXT_PUBLIC_IS_CLOUDso the provider initializes.Written for commit c014f7f. Summary will update on new commits.
Summary by CodeRabbit
Bug Fixes
Tests