-
Notifications
You must be signed in to change notification settings - Fork 3
Add backup policy migration support #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
premtsd-code
wants to merge
4
commits into
main
Choose a base branch
from
backup-migration-multitype
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d3084fb
Add backup policy migration support
premtsd-code 4e9b357
Use STATUS_SKIPPED for CE backup policy import
premtsd-code 5352a2b
Add exportGroupBackups to MockSource test adapter
premtsd-code 0075ba9
Merge branch 'main' into backup-migration-multitype
premtsd-code File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| <?php | ||
|
|
||
| namespace Utopia\Migration\Resources\Backups; | ||
|
|
||
| use Utopia\Migration\Resource; | ||
| use Utopia\Migration\Transfer; | ||
|
|
||
| class Policy extends Resource | ||
| { | ||
| /** | ||
| * @param string $id | ||
| * @param string $name | ||
| * @param array<string> $services | ||
| * @param int $retention | ||
| * @param string $schedule | ||
| * @param bool $enabled | ||
| * @param string $resourceId | ||
| * @param string $resourceType | ||
| */ | ||
| public function __construct( | ||
| string $id = '', | ||
| private readonly string $name = '', | ||
| private readonly array $services = [], | ||
| private readonly int $retention = 0, | ||
| private readonly string $schedule = '', | ||
| private readonly bool $enabled = true, | ||
| private readonly string $resourceId = '', | ||
| private readonly string $resourceType = '', | ||
| ) { | ||
| $this->id = $id; | ||
| } | ||
|
|
||
| /** | ||
| * @param array<string, mixed> $array | ||
| * @return self | ||
| */ | ||
| public static function fromArray(array $array): self | ||
| { | ||
| return new self( | ||
| $array['id'], | ||
| $array['name'] ?? '', | ||
| $array['services'] ?? [], | ||
| $array['retention'] ?? 0, | ||
| $array['schedule'] ?? '', | ||
| $array['enabled'] ?? true, | ||
| $array['resourceId'] ?? '', | ||
| $array['resourceType'] ?? '', | ||
| ); | ||
|
Comment on lines
+37
to
+48
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Harden Line 40 assumes 💡 Proposed fix public static function fromArray(array $array): self
{
+ if (!isset($array['id']) || !\is_string($array['id']) || $array['id'] === '') {
+ throw new \InvalidArgumentException('Backup policy "id" is required.');
+ }
+
return new self(
$array['id'],
$array['name'] ?? '',
$array['services'] ?? [],
$array['retention'] ?? 0,
$array['schedule'] ?? '',
$array['enabled'] ?? true,
$array['resourceId'] ?? '',
$array['resourceType'] ?? '',
);
}🤖 Prompt for AI Agents |
||
| } | ||
|
|
||
| /** | ||
| * @return array<string, mixed> | ||
| */ | ||
| public function jsonSerialize(): array | ||
| { | ||
| return [ | ||
| 'id' => $this->id, | ||
| 'name' => $this->name, | ||
| 'services' => $this->services, | ||
| 'retention' => $this->retention, | ||
| 'schedule' => $this->schedule, | ||
| 'enabled' => $this->enabled, | ||
| 'resourceId' => $this->resourceId, | ||
| 'resourceType' => $this->resourceType, | ||
| ]; | ||
| } | ||
|
|
||
| public static function getName(): string | ||
| { | ||
| return Resource::TYPE_BACKUP_POLICY; | ||
| } | ||
|
|
||
| public function getGroup(): string | ||
| { | ||
| return Transfer::GROUP_BACKUPS; | ||
| } | ||
|
|
||
| public function getPolicyName(): string | ||
| { | ||
| return $this->name; | ||
| } | ||
|
|
||
| /** | ||
| * @return array<string> | ||
| */ | ||
| public function getServices(): array | ||
| { | ||
| return $this->services; | ||
| } | ||
|
|
||
| public function getRetention(): int | ||
| { | ||
| return $this->retention; | ||
| } | ||
|
|
||
| public function getSchedule(): string | ||
| { | ||
| return $this->schedule; | ||
| } | ||
|
|
||
| public function getEnabled(): bool | ||
| { | ||
| return $this->enabled; | ||
| } | ||
|
|
||
| public function getResourceId(): string | ||
| { | ||
| return $this->resourceId; | ||
| } | ||
|
|
||
| public function getResourceType(): string | ||
| { | ||
| return $this->resourceType; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.