Skip to content

More 3.0 causal conversions#4822

Merged
invisig0th merged 8 commits intosynapse-3xxfrom
visi-3x-moar-causal
Mar 23, 2026
Merged

More 3.0 causal conversions#4822
invisig0th merged 8 commits intosynapse-3xxfrom
visi-3x-moar-causal

Conversation

@invisig0th
Copy link
Copy Markdown
Contributor

@invisig0th invisig0th commented Mar 20, 2026

Summary

Continues the migration of forms to use ``meta:causal``-style interfaces, adding new interfaces and forms for negotiations, discoveries, document signing, theft, and victimization.

New Interfaces

  • ``meta:negotiable`` (``base.py``) - marker interface for activities that involve negotiation; applied to ``risk:extortion``
  • ``doc:signable`` (``doc.py``) - interface for documents that can be signed; adds ``:signed`` (time) prop; applied to ``doc:contract``
  • ``entity:stance`` (``entity.py``) - interface for asks/offers in a negotiation; adds ``:value``, ``:expires``, ``:activity`` (``meta:negotiable``) props; base for ``entity:asked`` and ``entity:offered``
  • ``risk:victimized`` (``risk.py``) - interface for malicious acts with a direct victim; adds ``:victim`` (``entity:actor``) and ``:victim:name`` (``entity:name``) props; applied to ``risk:compromise``, ``risk:leak``, ``risk:extortion``, ``risk:theft``

New Forms

  • ``entity:discovered`` - event where an actor made a discovery; ``:item`` (``meta:discoverable``)
  • ``entity:signed`` - event where an actor signed a document; ``:doc`` (``doc:signable``)
  • ``entity:asked`` - event where an actor made an ask in a negotiation; inherits ``entity:stance``
  • ``entity:offered`` - event where an actor made an offer in a negotiation; inherits ``entity:stance``
  • ``risk:theft`` - event where an actor stole from a victim; ``:value`` (``econ:price``); edges: ``-(stole)>`` ``meta:observable`` and ``phys:object``

Interface Additions to Existing Forms

  • ``entity:conflict`` - added ``base:activity`` interface (adds ``:period``)
  • ``econ:purchase`` - added ``entity:event`` interface; ``:buyer`` replaced by ``:actor``; ``:paid`` changed from ``bool`` to ``time``; ``:paid:time`` removed
  • ``econ:payment`` - added ``entity:event`` interface; ``:payer`` replaced by ``:actor``; ``:payer:instrument`` renamed to ``:instrument``
  • ``sci:experiment`` - added ``entity:activity`` interface (adds ``:actor``, ``:period``)
  • ``sci:observation`` - added ``entity:event`` interface (adds ``:actor``, ``:time``)
  • ``pol:election``, ``pol:race`` - added ``base:activity`` interface
  • ``pol:term``, ``pol:candidate`` - added ``entity:activity`` interface; ``:contact`` replaced by ``:actor``
  • ``risk:compromise`` - added ``risk:victimized`` and ``meta:discoverable`` interfaces; ``:target`` replaced by ``:victim``; ``:loss:econ`` renamed to ``:cost``; removed ``:detected``, ``:campaign``, ``:theft:price``, ``:ransom:paid``, ``:ransom:price``, ``:response:cost``
  • ``risk:leak`` - added ``risk:victimized`` interface; ``vertexproject`` replaced by ``:victim``; ``:public:urls`` renamed to ``:urls``; removed ``:compromise``, ``:extortion``
  • ``risk:extortion`` - added ``risk:victimized`` and ``meta:negotiable`` interfaces; removed ``:demanded``, ``:deadline``, ``:demanded:payment:price``, ``:payments``

Removed

  • ``risk:extortion:status:taxonomy`` - replaced by ``risk:theft``
  • ``doc:contract`` ``:signers``, ``:completed``, ``:terminated`` props
  • ``entity:campaign`` ``:conflict`` prop (overfit)
  • ``econ:adjustable`` protocol refs from ``econ:purchase``, ``econ:payment``, ``econ:statement``, ``entity:campaign``

Edge Changes

  • Replaced ``risk:compromise -(stole)>`` edges with ``risk:theft -(stole)>`` edges
  • Added ``risk:attack -(ledto)> risk:outage`` and ``risk:extortion -(ledto)> econ:payment`` explicit causal edges
  • Removed several redundant ``-(caused)>`` edges in favor of ``-(ledto)>``

@invisig0th invisig0th changed the base branch from master to synapse-3xx March 20, 2026 13:49
Update test coverage for all WIP model changes: ``risk:victimized``
interface, new ``risk:theft`` form, ``entity:discovered``,
``entity:signed``, ``entity:asked``, ``entity:offered`` forms,
``doc:signable`` interface, ``entity:stance`` interface,
``meta:negotiable`` interface, and interface additions to
``econ:purchase``, ``econ:payment``, ``sci:experiment``,
``sci:observation``, ``pol:term``, ``pol:candidate``, and
``entity:conflict``.
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.41%. Comparing base (dd14217) to head (9298e44).
⚠️ Report is 1 commits behind head on synapse-3xx.

Additional details and impacted files
@@               Coverage Diff               @@
##           synapse-3xx    #4822      +/-   ##
===============================================
- Coverage        96.41%   96.41%   -0.01%     
===============================================
  Files              256      256              
  Lines            62385    62385              
===============================================
- Hits             60151    60150       -1     
- Misses            2234     2235       +1     
Flag Coverage Δ
linux 96.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@invisig0th invisig0th marked this pull request as ready for review March 23, 2026 18:03
@invisig0th invisig0th merged commit 852db85 into synapse-3xx Mar 23, 2026
5 checks passed
@invisig0th invisig0th deleted the visi-3x-moar-causal branch March 23, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants