RSDK-13355: remove reconfigure#1167
Open
aldenh-viam wants to merge 1 commit intoviamrobotics:mainfrom
Open
Conversation
aldenh-viam
force-pushed
the
push-tllqywwkkpkx
branch
2 times, most recently
from
029f942 to
9a2f335
Compare
aldenh-viam
force-pushed
the
push-tllqywwkkpkx
branch
from
9a2f335 to
7a26220
Compare
aldenh-viam
commented
Mar 18, 2026
| from viam.proto.app.robot import ComponentConfig | ||
| from viam.proto.common import ResourceName | ||
| from viam.resource.base import ResourceBase | ||
|
|
||
|
|
||
| @runtime_checkable | ||
| class Reconfigurable(Protocol): |
Contributor
Author
There was a problem hiding this comment.
Should we remove this class completely? Or not, because it would crash at runtime for users who bump the SDK version but forget to remove it from their code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modules no longer need to implement
Reconfigureafter viamrobotics/rdk#5811, sinceReconfigureResourcewill not be called byviam-serveranymore and it will instead always close (RemoveResource) and recreate (AddResource) the resource.