Fix packaged Node runtime loading and graceful shutdown#5
Merged
Conversation
vicary
force-pushed
the
fix/node-plugin-build-shims
branch
from
5d19355 to
c44aab0
Compare
vicary
added a commit
that referenced
this pull request
Apr 6, 2026
- fix packaged Node runtime module resolution by anchoring `createRequire(...)` to cwd-backed runtime files and add a packaging assertion to catch DNT import-meta ponyfill regressions - fix graceful `SIGINT` shutdown in Node-style hosts by preserving signal listeners during graceful teardown and explicitly exiting the process once teardown completes - add unit, integration, and subprocess smoke coverage for first-press graceful shutdown behavior - [x] `deno test src/index.test.ts src/services/runtime-teardown.test.ts src/services/runtime-teardown.smoke.test.ts src/services/session-mcp-runtime.test.ts` - [x] `deno test --allow-run --allow-read=\"src/services/runtime-teardown.smoke-fixture.ts\" src/services/runtime-teardown.smoke.test.ts` - [x] `deno task check` - [x] `deno task lint` - [x] `deno task fmt --check`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createRequire(...)to cwd-backed runtime files and add a packaging assertion to catch DNT import-meta ponyfill regressionsSIGINTshutdown in Node-style hosts by preserving signal listeners during graceful teardown and explicitly exiting the process once teardown completesTest Plan
deno test src/index.test.ts src/services/runtime-teardown.test.ts src/services/runtime-teardown.smoke.test.ts src/services/session-mcp-runtime.test.tsdeno test --allow-run --allow-read=\"src/services/runtime-teardown.smoke-fixture.ts\" src/services/runtime-teardown.smoke.test.tsdeno task checkdeno task lintdeno task fmt --check