Fix: reduce timeline flickering and generate video thumbnails#79
Closed
beezly wants to merge 3 commits intoviktorstrate:mainfrom
Closed
Fix: reduce timeline flickering and generate video thumbnails#79beezly wants to merge 3 commits intoviktorstrate:mainfrom
beezly wants to merge 3 commits intoviktorstrate:mainfrom
Conversation
…trate#72) AvatarImage and UserAvatarPlaceholder both used GeometryReader internally. When placed inside small fixed-size frames, GeometryReader caused layout issues — content defaulted to top-leading alignment, clipping the bottom. AvatarImage now uses .scaledToFill() directly. UserAvatarPlaceholder uses .minimumScaleFactor(0.01) for font sizing instead of reading geometry. Fixes viktorstrate#72
NSTableView recycles rows, which resets @State and causes images to flash back to placeholder. Add an NSCache-based image cache to MatrixClient with a synchronous cachedImage() lookup. AvatarImage, MessageImageView, and MatrixImageView all pre-populate their @State from the cache in init, so the first frame already has the image. Also suppresses implicit animation on the avatar swap. MatrixImageView now shows a gray placeholder immediately when mediaSource is nil instead of a perpetual spinner.
Timeline flickering fixes: - Pass real timeline to measurement view (was using nil, producing wrong heights) - Skip full snapshot rebuild when item IDs unchanged (content-only updates like reactions, read receipts) — reload only visible rows in place - Guard visibleRows.length > 0 before noteHeightOfRows - Re-measure visible rows after snapshot apply - Return max(height, 1) to avoid zero-height rows Video thumbnail fixes: - Show gray placeholder immediately when no thumbnailSource - Generate thumbnails locally using AVAssetImageGenerator - Cache generated thumbnails in the shared NSCache
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses multiple causes of timeline flickering and adds local video thumbnail generation.
Timeline Flickering Fixes
heightOfRowwas measuring rows withtimeline: nil, producing wrong heights. Fixed by passing the realtimelineto the measurement view.updateTimelineItemsrebuilt the entire diffable data source snapshot on every update. Now skips the full rebuild when item IDs haven't changed (content-only updates like reactions, read receipts) and reloads only visible rows in place.visibleRows.length > 0check beforenoteHeightOfRows.max(height, 1)to avoid zero-height rows.Video Thumbnail Fixes
thumbnailSourceshowed a perpetual spinner. Now shows a gray placeholder immediately.AVAssetImageGenerator— downloads the video file in the background and extracts the first frame.NSCachefor reuse.Files Changed
Mactrix/Views/ChatView/TimelineView/TimelineTableView.swiftMactrix/Views/ChatView/MessageVideoView.swift