Merged
Conversation
- Remove $HOME/.bun/install (entire directory) instead of just $HOME/.bun/install/cache — catches metadata files outside cache/ - Guard against BUN_INSTALL_CACHE_DIR pointing to a custom location Co-authored-by: Darcy Clarke <darcy@darcyclarke.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden the
clean_bun_cache()function to ensure all bun caches are fully cleaned between benchmark runs.Changes
$HOME/.bun/install(entire directory) instead of just$HOME/.bun/install/cache— catches metadata files that live outsidecache/$BUN_INSTALL_CACHE_DIR— if this env var is set to a custom location, that directory is also removedContext
The existing cleanup (
bun pm cache rm+ removing~/.bun/install/cache) covers the main package cache but misses potential metadata files in~/.bun/install/outside thecache/subdirectory. Also adds a safety net for environments whereBUN_INSTALL_CACHE_DIRpoints to a non-default location.Co-authored-by: Darcy Clarke darcy@darcyclarke.me