fix package name and update version#58752
Conversation
ahesford
left a comment
There was a problem hiding this comment.
In the future, please refrain from closing existing PRs and opening another to propose the same change. Not only does it create more noise and churn for project members, but it obfuscates the review history that led you to the current state of things.
Renames are generally painful but, when necessary, they require transitional packages with the old names to provide a proper upgrade path. Please grep through the repo for packages with descriptions containing the text "transitional dummy package" to see how that is done.
The commit message should be consistent with our usual style. Please look at the git history to ensure that you are consistent. Something like
xapps: update to 3.2.1, rename to xapp
would be appropriate.
srcpkgs/xapp/template
Outdated
| hostmakedepends="pkg-config meson ninja gettext libdbusmenu-gtk3 libdbusmenu-gtk3-devel gtk-update-icon-cache" | ||
| makedepends="glib-devel dbus-devel gtk+3-devel gdk-pixbuf-devel cairo-devel libX11-devel libgnomekbd-devel python3-gobject-devel" |
There was a problem hiding this comment.
These lines should be wrapped at 80 characters.
srcpkgs/xapp/template
Outdated
| depends="inxi xfconf" | ||
| short_desc="Cross-desktop libraries and common resources from Linux Mint" | ||
| maintainer="Michael Aldridge <maldridge@voidlinux.org>" | ||
| maintainer="Antonio Volpicelli AntoFox <nioanto@live.it>" |
There was a problem hiding this comment.
Don't kidnap packages from other maintainers, and also defer adoption until you've established a history of reliable package maintenance. Finally, ping the template maintainer when you touch a package. @the-maldridge
There was a problem hiding this comment.
Thank you for the feedback and guidance. I apologize for:
- Closing the original PR - I understand now that this creates unnecessary noise and loses review history
- Attempting to change the maintainer without permission - I've restored the original maintainer
I've now:
- Added the transitional dummy package for xapps
- Corrected hostmakedepends and makedepends
- Force-pushed to update this PR with the changes
I appreciate your patience as I learn the project's workflow and standards
|
The transitional packages (which include both |
|
Hello, I am currently working on updating the entire Cinnamon stack to 6.6.x (including Since Cinnamon 6.6.x depends on the recent XApp changes, I was planning to include the Would you prefer if I incorporate your changes into my larger Cinnamon update PR, or should I wait for this to land first? I've already updated |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Oh, I'm not the only one :D Both solution are fine for me. PS: if you need help on cinnamon/mate/kde stack feel free to contact me |
|
@nioanto Hello! Yes, sorry in advance because I hijacked your rename work because I also wanted to try last night updating the whole Cinnamon in one go, but it looks like my PR will be waiting on your PR. My suggestion is please follow the manual to also update references in several templates and common/shlib like I have done #58992 so my PR won't have many conflicts with yours. Cheers, thank you 🤩 |
Testing the changes
New package