Skip to content

chore(deps): remove unused google>=3.0.0 dependency#59

Open
omergulen wants to merge 1 commit intovolcengine:mainfrom
omergulen:chore/remove-unused-google-dependency
Open

chore(deps): remove unused google>=3.0.0 dependency#59
omergulen wants to merge 1 commit intovolcengine:mainfrom
omergulen:chore/remove-unused-google-dependency

Conversation

@omergulen
Copy link

Summary

Remove the google>=3.0.0 dependency from setup.py and requirements.txt. This package is unused and was added by mistake.

Background

The dependency was introduced accidentally in commit 7b3ec4a7 (2020-11-09) when google-api-python-client was shortened to google during the package rebranding from ttvcloud to volc.

The google package on PyPI (by Mario Vilas) is a Google Search scraper — it has nothing to do with google.protobuf. All from google.protobuf imports in this codebase are satisfied by the protobuf package, which is already a separate dependency.

Verification

A search of the entire codebase confirms:

  • Zero files import anything from the google PyPI package
  • Every from google.protobuf import resolves via the protobuf package
  • Neither google-api-python-client nor google was ever used in any service module

Impact

  • Removes an unused, unmaintained (last release: 2020) transitive dependency
  • Also drops the unnecessary transitive dependency on beautifulsoup4
  • No functional changes — no code references this package

Changes

  • setup.py: removed "google>=3.0.0" from install_requires
  • requirements.txt: removed google>=3.0.0

The `google>=3.0.0` dependency was introduced accidentally in commit
7b3ec4a (2020-11-09) when `google-api-python-client` was shortened
to `google` during a package rebranding from ttvcloud to volc.

The `google` PyPI package (by Mario Vilas) is a Google Search scraper —
completely unrelated to `google.protobuf`. All `from google.protobuf`
imports in this codebase are satisfied by the `protobuf` package, which
is already listed as a separate dependency.

Zero files in this repository import anything from the `google` PyPI
package. Removing it also drops the unnecessary transitive dependency
on `beautifulsoup4`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant