chore(deps): remove unused google>=3.0.0 dependency#59
Open
omergulen wants to merge 1 commit intovolcengine:mainfrom
Open
chore(deps): remove unused google>=3.0.0 dependency#59omergulen wants to merge 1 commit intovolcengine:mainfrom
omergulen wants to merge 1 commit intovolcengine:mainfrom
Conversation
The `google>=3.0.0` dependency was introduced accidentally in commit 7b3ec4a (2020-11-09) when `google-api-python-client` was shortened to `google` during a package rebranding from ttvcloud to volc. The `google` PyPI package (by Mario Vilas) is a Google Search scraper — completely unrelated to `google.protobuf`. All `from google.protobuf` imports in this codebase are satisfied by the `protobuf` package, which is already listed as a separate dependency. Zero files in this repository import anything from the `google` PyPI package. Removing it also drops the unnecessary transitive dependency on `beautifulsoup4`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
google>=3.0.0dependency fromsetup.pyandrequirements.txt. This package is unused and was added by mistake.Background
The dependency was introduced accidentally in commit
7b3ec4a7(2020-11-09) whengoogle-api-python-clientwas shortened togoogleduring the package rebranding fromttvcloudtovolc.The
googlepackage on PyPI (by Mario Vilas) is a Google Search scraper — it has nothing to do withgoogle.protobuf. Allfrom google.protobufimports in this codebase are satisfied by theprotobufpackage, which is already a separate dependency.Verification
A search of the entire codebase confirms:
googlePyPI packagefrom google.protobufimport resolves via theprotobufpackagegoogle-api-python-clientnorgooglewas ever used in any service moduleImpact
beautifulsoup4Changes
setup.py: removed"google>=3.0.0"frominstall_requiresrequirements.txt: removedgoogle>=3.0.0