Conversation
|
Test Comment Link : riteshfyi#5 (comment) |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8155fa67cb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| .filter(([pkg]) => packageVersions[pkg]) | ||
| .map(([pkg, prefix]) => { | ||
| const tag = `${prefix}-v${packageVersions[pkg]}`; | ||
| return `[\`${tag}\`](${repoUrl}/releases/tag/${tag})`; |
There was a problem hiding this comment.
Link pushed tags to tag pages instead of releases
The PR comment builds tag links as .../releases/tag/${tag}, but in the workflows I inspected this pipeline only creates and pushes Git tags (no GitHub Release creation step). In that setup, releases/tag/... URLs can point to missing release pages, so the “Released in” links in the comment break for contributors. Point to tag URLs (for example /tree/${tag} or /tags) or create releases before using release URLs.
Useful? React with 👍 / 👎.
COMPLETES #<SPARK-793038>
This pull request addresses
add a workflow to comment on merged pr's with the changes in versions & changelog url
by making the following changes
< DESCRIBE YOUR CHANGES >
wrote a workflow in deploy.cd
Change Type
The following scenarios were tested
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.