perf: refactor 'any' type detection for better performance and accuracy #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced expensive `typeToString` + Regex checks with `ts.TypeFlags` bitwise operations. - Added recursive union/intersection type checking to catch 'any' in complex types. - Reduced redundant calls to the TypeChecker to improve walk performance.
|
|
Member
|
I tested your solution, unfortunately it doesn't catch all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the script determines if a node is "typed" by converting the type to a string and running a Regex check (/\bany\b/). This is computationally expensive on large projects and can lead to false positives.
Changes
Recursive Flag Checking: Added isTypeMissing helper that utilizes type.flags and type.isUnion(). This is the native TypeScript way to identify any.
Performance: Avoids serializing complex types into strings unless absolutely necessary for the coverage output.
Bug Fix: Prevents types that simply contain the word "any" in their identifier (e.g., Company) from being misidentified as the any keyword.