ci: do not install recommended packages when using apt#513
ci: do not install recommended packages when using apt#513
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the Ubuntu CI prerequisite installation step to add the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
carlfriedrich
left a comment
There was a problem hiding this comment.
@sandr01d Good idea!
I think we could even improve speed more if we run the workflow in a prebuilt container. This would require building and storing the container image somewhere, though, which might make the build process a little less transparent. WDYT?
That's definitely interesting. The question to me is if the extra work having to maintain the containers is already worth it yet. After all our pipeline is not that slow at the moment. Maybe just caching the dependencies is enough? |
|
@sandr01d You're right, it's probably not worth it. So we should apply YAGNI here and just merge this. |
Check list
Description
Not installing recommended packages should speed up the CI. The speedup is probably very small, but because there is no downside to this I think we should take it.
Type of change
Summary by CodeRabbit