Skip to content

ci: do not install recommended packages when using apt#513

Open
sandr01d wants to merge 1 commit intowfxr:mainfrom
sandr01d:no-apt-recommends
Open

ci: do not install recommended packages when using apt#513
sandr01d wants to merge 1 commit intowfxr:mainfrom
sandr01d:no-apt-recommends

Conversation

@sandr01d
Copy link
Copy Markdown
Collaborator

@sandr01d sandr01d commented Apr 9, 2026

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have added unit tests for my code
  • I have made corresponding changes to the documentation

Description

Not installing recommended packages should speed up the CI. The speedup is probably very small, but because there is no downside to this I think we should take it.

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Test
  • Documentation change
  • CI

Summary by CodeRabbit

  • Chores
    • Optimized CI/CD pipeline by reducing unnecessary package dependencies, improving build efficiency.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a2afb58f-38ce-4f21-a387-a7b90caf575b

📥 Commits

Reviewing files that changed from the base of the PR and between 8a6dc7c and 318ecbc.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml

📝 Walkthrough

Walkthrough

Updated the Ubuntu CI prerequisite installation step to add the --no-install-recommends flag when installing zsh, fish, and shellcheck via apt-get, reducing unnecessary package dependencies while keeping the macOS and subsequent installation steps unchanged.

Changes

Cohort / File(s) Summary
CI Configuration
.github/workflows/ci.yaml
Added --no-install-recommends flag to apt-get install command for Ubuntu dependencies, reducing installed package footprint in CI environment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A single flag, so lean and clean,
No recommended bloat in between,
Ubuntu workflows now run light,
Dependencies trimmed just right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: adding the --no-install-recommends flag to apt installation commands in CI.
Description check ✅ Passed The description includes the required checklist with self-review confirmed, a clear explanation of the change and its rationale, and the CI type properly selected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sandr01d sandr01d marked this pull request as ready for review April 9, 2026 17:39
Copy link
Copy Markdown
Collaborator

@carlfriedrich carlfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandr01d Good idea!

I think we could even improve speed more if we run the workflow in a prebuilt container. This would require building and storing the container image somewhere, though, which might make the build process a little less transparent. WDYT?

@sandr01d
Copy link
Copy Markdown
Collaborator Author

sandr01d commented Apr 9, 2026

I think we could even improve speed more if we run the workflow in a prebuilt container. This would require building and storing the container image somewhere, though, which might make the build process a little less transparent. WDYT?

That's definitely interesting. The question to me is if the extra work having to maintain the containers is already worth it yet. After all our pipeline is not that slow at the moment. Maybe just caching the dependencies is enough?

@carlfriedrich
Copy link
Copy Markdown
Collaborator

@sandr01d You're right, it's probably not worth it. So we should apply YAGNI here and just merge this.

@carlfriedrich carlfriedrich self-requested a review April 12, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants