Skip to content

Improve image edit form #1209#1215

Open
lvdwijngaart wants to merge 2 commits intowger-project:masterfrom
lvdwijngaart:edit-exercise-image
Open

Improve image edit form #1209#1215
lvdwijngaart wants to merge 2 commits intowger-project:masterfrom
lvdwijngaart:edit-exercise-image

Conversation

@lvdwijngaart
Copy link

@lvdwijngaart lvdwijngaart commented Mar 21, 2026

Proposed Changes

  • Exercise Image add form has been abstracted into a ImageModal.tsx that can be used for adding and now also editing an existing image to an exercise.
  • Image Edit test has been added

Related Issue(s)

Closes issue #1209

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Tested locally and works

@lvdwijngaart lvdwijngaart marked this pull request as draft March 21, 2026 12:54
@lvdwijngaart lvdwijngaart marked this pull request as ready for review March 21, 2026 13:04
<Grid size={4}>
<img
style={{ width: "100%", borderRadius: '4px' }}
src={image.url}

Check failure

Code scanning / CodeQL

DOM text reinterpreted as HTML High

DOM text
is reinterpreted as HTML without escaping meta-characters.
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 75.178% (+0.2%) from 74.929%
when pulling 10daf4d on lvdwijngaart:edit-exercise-image
into 35347ac on wger-project:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants