Pass the correct iframe fallback URL to resource timing#12124
Open
noamr wants to merge 1 commit intowhatwg:mainfrom
Open
Pass the correct iframe fallback URL to resource timing#12124noamr wants to merge 1 commit intowhatwg:mainfrom
noamr wants to merge 1 commit intowhatwg:mainfrom
Conversation
This fixes a bug of havinga a dangling "url" variable. The name that is passed to resource timing is the parsed URL that was initially passed to the iframe for navigation. This codepath is "fallback resource timing" - it produces a resource timing entry for a cross-origin iframe that starts when the iframe is navigated and ends when the iframe's load event is fired, for iframes that don't produce actual resource timing based on fetch. This is tested by https://wpt.fyi/results/resource-timing/cross-origin-iframe.html Closes whatwg#12122
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug of havinga a dangling "url" variable.
The name that is passed to resource timing is the parsed URL that was initially passed to the iframe for navigation.
This codepath is "fallback resource timing" - it produces a resource timing entry for a cross-origin iframe that starts when the iframe is navigated and ends when the iframe's load event is fired, for iframes that don't produce actual resource timing based on fetch (cross-origin iframes without TAO).
This is tested by https://wpt.fyi/results/resource-timing/cross-origin-iframe.html
Closes #12122
/iframe-embed-object.html ( diff )