feat(query): support multiple sort fields with comma separator#13
Merged
feat(query): support multiple sort fields with comma separator#13
Conversation
- Allow sorting by multiple fields using comma-separated values (e.g., "Id,-Name") - Use OrderBy for first field and ThenBy for subsequent fields - Prefix "-" indicates descending order for each field - Update unit tests to verify multi-field sorting behavior - Add test query configuration and options for demo
There was a problem hiding this comment.
Pull request overview
This PR enhances the query sorting functionality to support multiple sort fields with individual sort directions, addressing issue #12. Users can now specify comma-separated field names in the sort parameter, with each field optionally prefixed with "-" for descending order.
Changes:
- Modified
ApplySortmethod to parse comma-separated sort fields and apply OrderBy for the first field and ThenBy for subsequent fields - Updated and expanded unit tests to verify multi-field sorting with various combinations of ascending and descending directions
- Added demo query options and configuration classes to illustrate the feature
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/AutoQuery/Extensions/QueryExtensions.cs | Refactored sorting logic to split comma-separated fields, iterate through them, and apply OrderBy/ThenBy based on position and direction |
| test/AutoQuery.Tests/Extensions/QueryExtensionsTests.cs | Updated test signature to verify both Id and Name, added three new test cases covering multi-field sorting scenarios |
| sample/AutoQueryApiDemo/Models/TestUserQueryOptions.cs | Added demo query options class with email filter and standard query parameters |
| sample/AutoQueryApiDemo/Configurations/TestUserQueryConfiguration.cs | Added demo configuration showing email filter setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSES #12