fix(react): Fix hydration mismatch for experimentalReactChildren#15146
Open
kedarvartak wants to merge 2 commits intowithastro:mainfrom
Open
fix(react): Fix hydration mismatch for experimentalReactChildren#15146kedarvartak wants to merge 2 commits intowithastro:mainfrom
kedarvartak wants to merge 2 commits intowithastro:mainfrom
Conversation
…ys for parsed children.
|
Contributor
|
Can you change this to go against |
ematipico
requested changes
Jan 30, 2026
| return c.data; | ||
| } else if (c.nodeType === Node.ELEMENT_NODE) { | ||
| return createReactElementFromDOMElement(c); | ||
| return createReactElementFromDOMElement(c, id, childKey++); |
Member
There was a problem hiding this comment.
If possible, please avoid post update expressions like this, because they are very easy to get wrong. Instead, let's do this
Suggested change
| return createReactElementFromDOMElement(c, id, childKey++); | |
| childKey += 1; | |
| return createReactElementFromDOMElement(c, id, childKey); |
|
|
||
| function createReactElementFromDOMElement(element: any, id?: number, key?: number): any { | ||
| if (id === undefined) { | ||
| id = clientIds++; |
Member
There was a problem hiding this comment.
Same here
Suggested change
| id = clientIds++; | |
| clientIds += 1; | |
| id = clientIds; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hydration mismatch when using
experimentalReactChildrenoption.Problem
When
experimentalReactChildren=true, children passed to React components had inconsistent prop handling between server and client:classtoclassNameand generated uniquekeypropsThis caused React warnings and hydration errors:
Solution
Updated the client-side createReactElementFromDOMElement function in client.ts to:
Testing
Added unit tests for class-to-className mapping and key generation. All existing tests pass.
Closes #15102