Fix: PSH flag must be set on last segment#52
Merged
gasbytes merged 2 commits intowolfSSL:masterfrom Mar 2, 2026
Merged
Conversation
danielinux
force-pushed
the
fix_psh_last_seg
branch
from
d632302 to
93bb19b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes TCP segmentation flagging so that PSH is applied to the last segment in a queued send “train” (rather than the first), aligning behavior with typical TCP PSH semantics and the reported issue.
Changes:
- Update
wolfIP_sock_sendto()TCP path to set PSH after enqueuing, on the last queued segment. - Adjust the unit test to validate PSH on the last (second) segment and configure
peer_mssto ensure deterministic segmentation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/wolfip.c |
Removes PSH-from-first-segment behavior and adds logic to set PSH on the last queued TCP segment. |
src/test/unit/unit.c |
Updates the TCP multi-segment send test expectations and sets peer_mss to force a 2-segment enqueue. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gasbytes
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a train of packets, the last TCP segment is the one that should be marked with PSH, not the first.
Found via fenrir/240