Validate minimum TCP header length#53
Merged
gasbytes merged 1 commit intowolfSSL:masterfrom Mar 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens TCP packet parsing by rejecting segments whose TCP data-offset (header length) indicates a header smaller than the minimum 20 bytes, preventing malformed packets from being processed.
Changes:
- Add a minimum TCP header-length (data offset) check in
tcp_input()to drop malformed segments early. - Add a unit test covering the “header length below minimum” drop behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/wolfip.c |
Adds a minimum TCP header-length validation before computing payload length / processing options. |
src/test/unit/unit.c |
Introduces a regression test ensuring malformed short-header TCP segments are dropped without state changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gasbytes
approved these changes
Mar 2, 2026
Contributor
gasbytes
left a comment
gasbytes
left a comment
There was a problem hiding this comment.
lgtm, checked via gh pr checkout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discard malformed TCP packets that are too short.
Found by fenrir/224