Fix off-by-one comparison in space calculation#54
Merged
gasbytes merged 1 commit intowolfSSL:masterfrom Mar 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an off-by-one comparison in the FIFO wrap-to-zero space check so that enqueues are allowed when tail == needed (i.e., exactly enough contiguous space at the start of the ring buffer after wrapping). This aligns the wrap decision with the later contiguous-space check (head + needed > tail) and prevents rejecting a valid enqueue.
Changes:
- In
fifo_push()andfifo_can_push_len(), change the wrap rejection condition fromtail <= neededtotail < needed. - Add unit tests covering the
tail == neededwrap boundary for bothfifo_push()andfifo_can_push_len().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/wolfip.c | Corrects the wrap-to-zero boundary comparison to allow exact-fit inserts at the start of the FIFO. |
| src/test/unit/unit.c | Adds targeted tests to prevent regression on the tail == needed wrap boundary behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gasbytes
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by fenrir/144