Fix endianness of default DHCP offer netmask#56
Merged
philljj merged 4 commits intowolfSSL:masterfrom Mar 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the byte-order of the default subnet mask applied during DHCP OFFER parsing when the server does not provide an explicit subnet mask option, ensuring the internal ipconf.mask is set correctly (e.g., /24 becomes 255.255.255.0).
Changes:
- Correct the default DHCP OFFER netmask constant so it is converted into the proper internal (host-order) mask value.
- Add a unit test covering the “missing subnet mask option” DHCP OFFER path.
- Register the new unit test in the test suite.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/wolfip.c |
Adjusts the default DHCP OFFER netmask initialization to match the parser’s endianness conversion behavior. |
src/test/unit/unit.c |
Adds and registers a regression test asserting the default /24 mask is applied when no mask option is present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
philljj
requested changes
Mar 2, 2026
danielinux
force-pushed
the
dhcp-default-netmask
branch
from
371a37d to
03ba436
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
philljj
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no netmask is offered and we are using the default 24bit netmask, ensure it's set with the right endianness.
Found by fenrir/141