Fix custom attributes to be nullable#558
Closed
blackmad-cradle wants to merge 3 commits intoworkos:mainfrom
Closed
Fix custom attributes to be nullable#558blackmad-cradle wants to merge 3 commits intoworkos:mainfrom
blackmad-cradle wants to merge 3 commits intoworkos:mainfrom
Conversation
This reverts commit 2ce9c79.
Contributor
Greptile SummaryThis PR makes two related improvements to the type definitions:
These changes improve type correctness by allowing these fields to be absent when not applicable, preventing serialization issues when the API doesn't return these values. Confidence Score: 5/5
Important Files Changed
Class Diagram%%{init: {'theme': 'neutral'}}%%
classDiagram
class AuthenticationResultCommon {
+Optional[str] ip_address
+Optional[str] user_agent
}
class AuthenticationResultSucceeded {
+Literal["succeeded"] status
+str email
}
class AuthenticationResultFailed {
+Literal["failed"] status
+ErrorWithCode error
+Optional[str] email
+Optional[str] user_id
}
class AuthenticationSsoData {
+Optional[str] connection_id
+Optional[str] organization_id
+Optional[str] session_id
}
class AuthenticationSsoSucceededPayload {
+Literal["sso"] type
+Optional[str] user_id
+Optional[AuthenticationSsoData] sso
}
class AuthenticationSsoFailedPayload {
+Literal["sso"] type
+Optional[AuthenticationSsoData] sso
}
AuthenticationResultCommon <|-- AuthenticationResultSucceeded
AuthenticationResultCommon <|-- AuthenticationResultFailed
AuthenticationResultSucceeded <|-- AuthenticationSsoSucceededPayload
AuthenticationResultFailed <|-- AuthenticationSsoFailedPayload
AuthenticationSsoSucceededPayload --> AuthenticationSsoData
AuthenticationSsoFailedPayload --> AuthenticationSsoData
Last reviewed commit: 5018d64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.