Remove outdated retroreflective tape documentation and add game piece detection guide#3102
Draft
jasondaming wants to merge 5 commits intowpilibsuite:2027from
Draft
Remove outdated retroreflective tape documentation and add game piece detection guide#3102jasondaming wants to merge 5 commits intowpilibsuite:2027from
jasondaming wants to merge 5 commits intowpilibsuite:2027from
Conversation
… detection guide Removes three outdated articles about retroreflective tape that are no longer relevant since FRC games now use AprilTag-based localization instead. Adds a new comprehensive guide for detecting game pieces using modern vision processing techniques. Changes: - Remove target-info-and-retroreflection.rst (2016 game-specific) - Remove identifying-and-processing-the-targets.rst (outdated methods) - Remove 2017-vision-examples.rst (LabVIEW-only examples) - Add game-piece-detection.rst with guidance on traditional vision vs ML, coordinate transformations, and pose estimation - Update introduction/index.rst to reflect new article structure - Update apriltag-intro.rst to remove outdated repository fork language Fixes wpilibsuite#2957
Update references in basic-vision-example.rst and working-with-contours.rst to point to the new game-piece-detection.rst article instead of the deleted identifying-and-processing-the-targets.rst file.
Add redirects from the three deleted retroreflective tape articles to the new game-piece-detection.rst article to maintain link compatibility.
…mendations - Add comprehensive camera selection section covering FOV, resolution, frame rate, exposure control, and camera types - Add important note about ML hardware requirements and accelerator options (Google Coral, Limelight, Orange Pi NPU) - Add PhotonVision reference and link in strategies-for-vision-programming.rst - Clarify that teams commonly use Google Coral with Orange Pi + PhotonVision or Limelight with integrated acceleration
- Remove incorrect claim about Limelight with built-in ML support - Clarify Google Coral works with any coprocessor, not just PhotonVision - Add Hailo-8 as another accelerator option - Simplify language to be more accurate about hardware options
katzuv
reviewed
Oct 11, 2025
| 3. Gradle & Maven publishing support | ||
|
|
||
| .. todo:: Work in this library is still ongoing, this list may change in the future. | ||
| The AprilTag library is integrated into WPILib and PhotonVision, making it easy to use AprilTags for robot localization and alignment. |
Contributor
There was a problem hiding this comment.
Suggested change
| The AprilTag library is integrated into WPILib and PhotonVision, making it easy to use AprilTags for robot localization and alignment. | |
| The AprilTag library is integrated into WPILib, PhotonVision and Limelight, making it easy to use AprilTags for robot localization and alignment. |
Collaborator
There was a problem hiding this comment.
Does limelight use WPILib's fork of the Apriltag library? Thats what this implies, but I don't think I could prove it one way or the other. I think the language would need to be generalized besides just adding limelight.
Contributor
There was a problem hiding this comment.
Maybe I was indeed too quick. LimelightHelpers doesn't seem to be using it
Collaborator
There was a problem hiding this comment.
I wouldn't expect LimelightHelpers to use it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Removed Files
target-info-and-retroreflection.rst- 2016 game-specific retroreflective tape documentationidentifying-and-processing-the-targets.rst- Outdated vision processing methods for retroreflective targets2017-vision-examples.rst- LabVIEW-only vision examplesAdded Files
game-piece-detection.rst- New comprehensive guide covering:Modified Files
introduction/index.rst- Updated to reflect new article structureapriltag/apriltag-intro.rst- Removed outdated "forked repository" language and TODO noteFixes #2957