Merged
Conversation
…d install script to install to Aquiis folder instead of root Applications folder.
xnodeoncode
added
documentation
xskcdf
approved these changes
Mar 17, 2026
There was a problem hiding this comment.
Pull request overview
Updates release tooling and Linux desktop integration to align versioning across Electron and .NET, and to install the AppImage into an app-specific directory to avoid clutter/collisions in ~/Applications.
Changes:
- Extend
bump-version.shto also bumpelectron.manifest.jsonbuildVersion. - Bump SimpleStart version from
1.1.2→1.1.3across.csproj,appsettings.json, andelectron.manifest.json. - Update Linux desktop integration installer to move the AppImage into
~/Applications/Aquiisand extract an icon from the AppImage for desktop integration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
bump-version.sh |
Adds Electron manifest version bump (and now participates in keeping versions in sync). |
4-Aquiis.SimpleStart/electron.manifest.json |
Updates buildVersion to 1.1.3. |
4-Aquiis.SimpleStart/appsettings.json |
Updates ApplicationSettings.Version to 1.1.3. |
4-Aquiis.SimpleStart/Assets/install-desktop-integration.sh |
Installs AppImage to ~/Applications/Aquiis and extracts/installs icon from AppImage. |
4-Aquiis.SimpleStart/Aquiis.SimpleStart.csproj |
Updates assembly/package versions to 1.1.3. |
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+83
to
+88
| ICON_PATH="application-x-executable" | ||
| EXTRACT_WORKDIR="$(mktemp -d)" | ||
|
|
||
| echo "Extracting icon from AppImage..." | ||
| (cd "$EXTRACT_WORKDIR" && "$APPIMAGE_PATH" --appimage-extract > /dev/null 2>&1) || true | ||
|
|
Comment on lines
110
to
112
| # Create desktop entry | ||
| cat > ~/.local/share/applications/aquiis.desktop << EOF | ||
| [Desktop Entry] |
Comment on lines
+84
to
+86
| # Update electron.manifest.json buildVersion | ||
| echo -e "${YELLOW}📝 Updating $ELECTRON_MANIFEST...${NC}" | ||
| sed -i "s|\"buildVersion\": \"[^\"]*\"|\"buildVersion\": \"$NEW_VERSION\"|g" "$ELECTRON_MANIFEST" |
| echo "" | ||
| echo "To completely remove Aquiis:" | ||
| echo " rm $APPIMAGE_PATH" | ||
| echo " rm -rf $APP_INSTALL_DIR" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated install script to install to Aquiis folder instead of root Applications folder.
Updated bump-version script to include electron.manifest.json.