Update setup.py#8
Open
wanjunling168 wants to merge 1 commit intoxxlong0:mainfrom
Open
Conversation
much reasonable and OK for Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
much reasonable (no
CFLAGStricks)I checked it under Windows and WSL, compile and import are both OK.
To build under Windows:
python setup.py build_ext --inplace --compiler=msvc(setuptools/distutils will callvcvarsall.bat, should be no worry about environment variables)To build under WSL:
python3 setup.py build_ext --inplace(just like before)Previous
setup.pywill fail under Windows due to a Cython's old issue [cython/cython#1480], success under Linux is due to thatCFLAGStrick which doesn't seem to work with MSVC.