Add s3 path nesting for profile and rendered buckets#80
Open
ArasakaWorker wants to merge 2 commits intoyandex:mainfrom
Open
Add s3 path nesting for profile and rendered buckets#80ArasakaWorker wants to merge 2 commits intoyandex:mainfrom
ArasakaWorker wants to merge 2 commits intoyandex:mainfrom
Conversation
Signed-off-by: Morozov Maksim <maksim.morozov@vkteam.ru>
tarokinoe
reviewed
Dec 17, 2025
| } | ||
|
|
||
| func TransformUUID(s string) string { | ||
| // Do not want to store all s3 files into root bucket, so make this workaroud for uuid |
There was a problem hiding this comment.
Suggested change
| // Do not want to store all s3 files into root bucket, so make this workaroud for uuid | |
| // Do not want to store all s3 files into root bucket, so make this workaround for uuid |
Signed-off-by: Morozov Maksim <maksim.morozov@vkteam.ru>
ArasakaWorker
force-pushed
the
add-s3-nesting
branch
from
4c36ae4 to
be9b2b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently all raw profiles and rendered flamegraphs are stored in root of s3 bucket which leads to s3 degradation after inserting thousands of elements. This PR is a suggestion to split s3 key names by
/. Wondering for the better place ofTransformUUIDfunction not to repeat it multiple times.Also ready to hear ideas about fixing
buildIDnames in binary bucket.