Conversation
|
Great job, no security vulnerabilities found in this Pull Request |
9e7970f to
7db890a
Compare
|
@psiinon fixed commit signatures. no way for me to rerun job. |
|
You need to do all of them. |
Signed-off-by: Johnathan P. Irvin <me@3xpl0173d.dev>
Signed-off-by: Johnathan P. Irvin <me@3xpl0173d.dev>
Signed-off-by: Johnathan P. Irvin <me@3xpl0173d.dev>
7db890a to
7d9d49d
Compare
|
@kingthorin thank you for clarification. should be fixed now. any other changes required? |
|
@kingthorin or @psiinon -- Any update? Looking to move this forward. |
|
If you want to move this forward generate the implementation instead of hand write it. |
There was a problem hiding this comment.
The existing examples already cover how the "scans" should be used.
|
The changelog should be updated. |
|
Where is the documentation to generate it automatically? Where should I place example usage? |
What should it say? |
|
Unable to get the build system to build the plugin to generate the api. Spent less time writing this simple addition then it takes to get automation tools to run. Maybe.. Will come back later. |
Signed-off-by: Johnathan P. Irvin <me@3xpl0173d.dev>
Added change log per request. |
|
Superseded by #156 which has the APIs automatically generated. |

Adds the client spider to the python api.