Skip to content

Comments

Add class properties to symbols outline#103

Merged
MrSubidubi merged 1 commit intozed-extensions:mainfrom
Klaas058:main
Feb 23, 2026
Merged

Add class properties to symbols outline#103
MrSubidubi merged 1 commit intozed-extensions:mainfrom
Klaas058:main

Conversation

@Klaas058
Copy link
Contributor

@Klaas058 Klaas058 commented Feb 6, 2026

Currently class properties are not outlined and therefore not showing up in the symbol search in Zed

Test case:

<?php

class TestCase
{
    public $noType;
    protected string $withType = "default";
    private static array $static = [];
    protected readonly bool $readOnly;

    public function __construct(public bool $promotedProperty) {}
}

Before this change:
image

After this change:
image

Ideally promoted class properties would also work, but this is a start.

@cla-bot
Copy link

cla-bot bot commented Feb 6, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @Klaas058 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@Klaas058
Copy link
Contributor Author

Klaas058 commented Feb 6, 2026

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Feb 6, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @Klaas058 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot
Copy link

cla-bot bot commented Feb 6, 2026

The cla-bot has been summoned, and re-checked this pull request!

@Klaas058
Copy link
Contributor Author

Klaas058 commented Feb 6, 2026

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Feb 6, 2026
@cla-bot
Copy link

cla-bot bot commented Feb 6, 2026

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good, thanks for this and also the before/after!

And congratulations to your first contribution! 🎉

@MrSubidubi MrSubidubi merged commit 4bf9ddb into zed-extensions:main Feb 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants