feat: migrate image storage from image_url field to world_heritage_site_images table by zigzagdev · Pull Request #396 · zigzagdev/world-heritage-api

zigzagdev · 2026-03-29T07:36:35Z

Summary

Images are now stored exclusively in world_heritage_site_images table
instead of world_heritage_sites.image_url / primary_image_url.

Changes

Define image mapping rules: main_image_url + images_urls → world_heritage_site_images #295 Define image mapping rules
Update importer: stop writing image_url, insert only images #296 Stop writing image_url in importer
Add de-duplication + idempotency (no duplicates on re-import) #297 Add de-duplication + idempotency (unique constraint on url_hash)
Fix detail API output (always return images array) #298 Fix detail API to return images array
Regression tests (import + API contract) #299 Add regression tests for image contract
Cleanup / backfill (optional, only if you already have legacy data) #300 Cleanup legacy fields
- Cleanup / backfill (optional, only if you already have legacy data) #300-1 Remove runtime usage of image_url
- Cleanup / backfill (optional, only if you already have legacy data) #300-2 Removeimage_url from test files and seeders
- Cleanup / backfill (optional, only if you already have legacy data) #300-3 Drop image_url / primary_image_url columns

Verification

php artisan app:world-heritage-build --fresh --jp --pretty --clear --algolia --algolia-truncate
All 1248 records processed
Images correctly stored in world_heritage_site_images
Detail API returns images array with correct shape

…mage_url-into-heritage-command chore: world_heritage-split-command-refactor

…model

…eQueryService

Fix/api detail layout

…est-fix test: add image contract tests for getHeritageById

…-command chore: remove runtime usage of image_url from commands and query services

chore: drop image_url column from world_heritage_sites

fix: fix image url key in split JSON and cleanup image_url references

Feat/clean up code

zigzagdev

Ok

Copilot

Pull request overview

Migrates world-heritage image handling away from legacy world_heritage_sites.image_url / primary_image_url columns and toward the world_heritage_site_images table, updating query paths, importer/normalizer behavior, and related tests/seed data.

Changes:

Drops legacy image_url / primary_image_url columns and removes seeder/test data that still referenced them.
Updates query/services and Algolia indexing to derive thumbnail/primary image from world_heritage_site_images.
Adjusts detail-query tests to validate the images array contract.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/database/seeders/WorldHeritageSeeder.php	Removes legacy `image_url` seed field.
src/database/migrations/2026_03_29_155722_drop_primary_image_url_from_world_heritage_sites.php	Drops `primary_image_url` column.
src/database/migrations/2026_03_29_151147_drop_image_url_from_world_heritage_sites.php	Drops `image_url` column.
src/app/Packages/Features/QueryUseCases/QueryServiceInterface/WorldHeritageQueryServiceInterface.php	Removes `getHeritagesByIds()` from the query service interface.
src/app/Packages/Domains/WorldHeritageReadQueryService.php	Uses primary image relation; used by Algolia search result hydration.
src/app/Packages/Domains/WorldHeritageQueryService.php	Switches list payload thumbnail source to images table; removes `getHeritagesByIds()` implementation; adjusts image DTO mapping.
src/app/Packages/Domains/Test/QueryService/WorldHeritageQueryService_getByIdTest.php	Adds/updates tests for `images` array contract and empty behavior.
src/app/Packages/Domains/Test/QueryService/WorldHeritageQueryService_countEachRegionTest.php	Removes legacy `image_url` from test record seed.
src/app/Models/WorldHeritage.php	Removes thumbnail relation/fillable related to legacy thumbnail setup.
src/app/Models/Image.php	Aligns Image model to `world_heritage_site_images` table usage and adds casting.
src/app/Models/Country.php	Removes an unused import.
src/app/Console/Commands/SplitWorldHeritageJson.php	Stops emitting legacy image fields; refactors URL extraction/deduplication.
src/app/Console/Commands/ImportWorldHeritageSiteFromSplitFile.php	Stops writing legacy `image_url` on site import.
src/app/Console/Commands/AlgoliaImportWorldHeritages.php	Loads primary image via relation for Algolia `thumbnail_url`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-29T07:41:02Z

src/app/Models/Image.php

+    public function casts(): array
+    {
+        return [
+            'is_primary' => 'boolean',
+        ];
+    }


For consistency with other models in this codebase (e.g. WorldHeritage), consider declaring this as protected function casts(): array (or using a $casts property). While increasing visibility works in PHP, keeping it consistent helps tooling and readability.

...Packages/Features/QueryUseCases/QueryServiceInterface/WorldHeritageQueryServiceInterface.php

Copilot · 2026-03-29T07:41:02Z

src/app/Packages/Domains/WorldHeritageReadQueryService.php

@@ -33,13 +33,15 @@ public function findByIdsPreserveOrder(array $ids): Collection
                'world_heritage_sites.latitude',
                'world_heritage_sites.longitude',
                'world_heritage_sites.short_description',


findByIdsPreserveOrder() feeds models into buildWorldHeritagePayload(), which includes unesco_site_url. Because this select list omits world_heritage_sites.unesco_site_url, search results built from these models will always return unesco_site_url as null. Include world_heritage_sites.unesco_site_url in the selected columns (or stop emitting it from the payload for this path).

Suggested change

'world_heritage_sites.short_description',

'world_heritage_sites.short_description',

'world_heritage_sites.unesco_site_url',

Copilot · 2026-03-29T07:41:02Z

src/app/Packages/Domains/WorldHeritageQueryService.php

    public function getAllHeritages(
        int $currentPage,
        int $perPage,
        string $order
-    ): PaginationDto
-    {
+    ): PaginationDto {
        $items = WorldHeritage::query()


This method signature puts the opening brace on the same line as the return type, while the rest of the class uses the brace on the next line. Since the repo uses Laravel Pint, this will likely be reformatted anyway; consider keeping it consistent (PSR-12 style) to avoid noisy diffs.

src/app/Packages/Domains/Test/QueryService/WorldHeritageQueryService_getByIdTest.php

Copilot · 2026-03-29T07:41:03Z

src/app/Console/Commands/SplitWorldHeritageJson.php

+            array $extra =
+            []


The default value for $extra is split across lines (array $extra = then []). This is valid PHP but inconsistent with the surrounding formatting and will likely be rewritten by Pint; please format it as a single parameter line (array $extra = []) or use a standard multiline style.

Suggested change

array $extra =

[]

array $extra = []

Copilot · 2026-03-29T07:41:03Z

src/database/migrations/2026_03_29_155722_drop_primary_image_url_from_world_heritage_sites.php

+    public function up(): void
+    {
+        Schema::table('world_heritage_sites', function (Blueprint $table) {
+                $table->dropColumn('primary_image_url');


Indentation inside the Schema::table callback is inconsistent here (the dropped column line is over-indented and the closing brace is misaligned). Please reformat to the standard indentation to keep migrations consistent and avoid Pint reformat churn.

Suggested change

$table->dropColumn('primary_image_url');

$table->dropColumn('primary_image_url');

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/app/Packages/Domains/WorldHeritageQueryService.php

src/app/Packages/Domains/WorldHeritageReadQueryService.php

src/app/Packages/Domains/WorldHeritageQueryService.php

src/database/migrations/2026_03_29_155722_drop_primary_image_url_from_world_heritage_sites.php

zigzagdev added 19 commits March 28, 2026 20:25

chore: world_heritage-split-command-refactor

08e3cb1

Merge pull request #386 from zigzagdev/chore/delete-command-writing-i…

22f12dc

…mage_url-into-heritage-command chore: world_heritage-split-command-refactor

refactor: remove thumbnail relation and image_url from WorldHeritage …

9cd28c8

…model

fix: replace image_url/thumbnail with images relation in WorldHeritag…

d152539

…eQueryService

refactor: update WorldHeritageQueryServiceInterface

41b8ab1

Merge pull request #387 from zigzagdev/fix/api-detail-layout

a92eff3

Fix/api detail layout

feat: add Eloquent cast into ImageModel

edb5fa1

fix: test content add

1ec6ad6

Merge pull request #388 from zigzagdev/chore/image_url-queryservice-t…

9dcfd6d

…est-fix test: add image contract tests for getHeritageById

chore: remove image_url from QueryService & Command

483fe27

Merge pull request #391 from zigzagdev/chore/remove-image_url-from-qs…

3814c75

…-command chore: remove runtime usage of image_url from commands and query services

chore: create new migration file

1fb3883

Merge pull request #393 from zigzagdev/feat/create-drop-migration-file

85a9865

chore: drop image_url column from world_heritage_sites

fix: failed tests

8937ebd

feat: drop redundant column

4a571c0

chore: delete redundant column from seeder

71a3e0f

fix: import key name

7fb4385

Merge pull request #394 from zigzagdev/fix/delete-redundant-code

8fe1569

fix: fix image url key in split JSON and cleanup image_url references

Merge pull request #395 from zigzagdev/feat/clean-up-code

7c42616

Feat/clean up code

github-actions bot added the backend label Mar 29, 2026

zigzagdev self-assigned this Mar 29, 2026

github-actions bot added the release label Mar 29, 2026

zigzagdev requested a review from Copilot March 29, 2026 07:36

zigzagdev linked an issue Mar 29, 2026 that may be closed by this pull request

Bug[🐛]: Fix UNESCO image import: store only images in world_heritage_site_images with stable ordering (no image_url writes) #294

Closed

zigzagdev commented Mar 29, 2026

View reviewed changes

Copilot started reviewing on behalf of zigzagdev March 29, 2026 07:37 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

fix: apply copilot review suggestions

03a13ca

zigzagdev requested a review from Copilot March 29, 2026 07:54

Copilot started reviewing on behalf of zigzagdev March 29, 2026 07:55 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

zigzagdev merged commit 83101e9 into main Mar 29, 2026
28 checks passed

zigzagdev deleted the chore/integrate-image_url-into-image-table branch March 29, 2026 08:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: migrate image storage from image_url field to world_heritage_site_images table#396

feat: migrate image storage from image_url field to world_heritage_site_images table#396
zigzagdev merged 20 commits intomainfrom
chore/integrate-image_url-into-image-table

zigzagdev commented Mar 29, 2026

Uh oh!

zigzagdev left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	'world_heritage_sites.short_description',
	'world_heritage_sites.short_description',
	'world_heritage_sites.unesco_site_url',

	$table->dropColumn('primary_image_url');
	$table->dropColumn('primary_image_url');

Conversation

zigzagdev commented Mar 29, 2026

Summary

Changes

Verification

Uh oh!

zigzagdev left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants