PR7: feat(conformers): isolated nvMolKit worker backend#23
Closed
SergeiNikolenko wants to merge 4 commits into
Closed
PR7: feat(conformers): isolated nvMolKit worker backend#23SergeiNikolenko wants to merge 4 commits into
SergeiNikolenko wants to merge 4 commits into
Conversation
dd4356e to
9e046e3
Compare
b4141c5 to
2104c18
Compare
- Extract _rdkit_generate_chunk() to eliminate 3x duplicated blocks - Consolidate max_failures/max_iterations into single max_attempts - Extract _conf_has_finite_coords predicate in worker CLI - Compact setup script: str.removeprefix(), f-strings, shorter docstrings - Remove 8 obvious/redundant comments
9e046e3 to
fdaef13
Compare
2104c18 to
9d0adcc
Compare
ce154ef to
c5ae26b
Compare
c3aa6f2 to
8d9ad19
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an isolated nvMolKit-based conformer worker backend.
Goal: provide a fast conformer path without coupling the main Matcha runtime environment to nvMolKit ABI/toolchain dependencies.
Motivation
In-process nvMolKit integration can make the core runtime environment fragile. This PR adopts a worker-process model:
What Changed
1) Isolated worker package
matcha-nvmolkit-workerpackage and worker CLI entrypoint.2) Setup and compatibility scripts
scripts/setup_nvmolkit_worker.pyfor environment bootstrap and smoke checks.scripts/nvmolkit_worker.pycompatibility wrapper.3) Runtime integration
MATCHA_CONFORMER_BACKEND=auto|rdkit|workerMATCHA_CONFORMER_WORKER_CMDMATCHA_CONFORMER_WORKER_TIMEOUT_SECMATCHA_CONFORMER_WORKER_CHUNK_SIZE4) Worker contract
input.sdf+params.jsonoutput.sdf+meta.jsonautobackend: fallback to RDKitworkerbackend: fail-fast5) Tests and docs
.gitignorefor worker setup/use.File-Level Scope
.gitignoreREADME.mdmatcha/utils/preprocessing.pypackages/matcha_nvmolkit_worker/README.mdpackages/matcha_nvmolkit_worker/pyproject.tomlpackages/matcha_nvmolkit_worker/src/matcha_nvmolkit_worker/__init__.pypackages/matcha_nvmolkit_worker/src/matcha_nvmolkit_worker/cli.pyscripts/nvmolkit_worker.pyscripts/setup_nvmolkit_worker.pytests/test_conformer_generation_batch.pytests/test_conformer_generation_in_memory.pytests/test_conformer_worker_contract.pyQuick Validation Command
6) Auto-setup on first use
MATCHA_CONFORMER_BACKEND=auto|workerand no worker command is configured/found,Matcha now performs a one-time automatic bootstrap via:
uv run python scripts/setup_nvmolkit_worker.py --skip-smokeMATCHA_CONFORMER_AUTO_SETUP_WORKER(default1)MATCHA_CONFORMER_WORKER_SETUP_TIMEOUT_SEC(default3600)auto, Matcha falls back to RDKit.workermode, Matcha fails fast with a clear install hint.Auto-setup Validation Command