Fix CwC crash when using skills form items and multiple link groups#9682
Open
Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Open
Fix CwC crash when using skills form items and multiple link groups#9682Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
Due to the triggerTime being on the support part that supports the triggering channeled skill the CwC handler relies on the triggerTime property stored in the skillData table of the trigger source skill. This is problematic since the slotMatch logic for triggered skills coming from items checks all socket groups in a given item regardless of whether they are crosslinked with cast while channeling or not. This pr reworks the trigger source finding logic for cast while channeling to both speed it up and fix this issue. Signed-off-by: Paliak <91493239+Paliak@users.noreply.github.com>
Signed-off-by: Paliak <91493239+Paliak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9664
Description of the problem being solved:
Due to the triggerTime being on the support part that supports the triggering channeled skill the CwC handler relies on the triggerTime property stored in the skillData table of the trigger source skill. This is problematic since the slotMatch logic for triggered skills coming from items checks all socket groups in a given item regardless of whether they are crosslinked with cast while channeling or not. This pr reworks the trigger source finding logic for cast while channeling to both speed it up and fix this issue.
Link to a build that showcases this PR: