Skip to content

Fix CwC crash when using skills form items and multiple link groups #9682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Paliak wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix CwC crash when using skills form items and multiple link groups #9682

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e42026e
FIX: CwC crash when using skills form items and multiple link groups
Paliak Mar 20, 2026
63c317f
FIX: only calc canSupport if not source
Paliak Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/Modules/CalcTriggers.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,18 +219,19 @@ end
local function CWCHandler(env)
if not env.player.mainSkill.skillFlags.minion and not env.player.mainSkill.skillFlags.disable then
local triggeredSkills = {}
local trigRate = 0
local source = nil
local triggerName = "Cast While Channeling"
local output = env.player.output
local breakdown = env.player.breakdown
for _, skill in ipairs(env.player.activeSkillList) do
local match1 = env.player.mainSkill.activeEffect.grantedEffect.fromItem and skill.socketGroup and skill.socketGroup.slot == env.player.mainSkill.socketGroup.slot
local match2 = (not env.player.mainSkill.activeEffect.grantedEffect.fromItem) and skill.socketGroup == env.player.mainSkill.socketGroup
if env.player.mainSkill.triggeredBy.gemData and calcLib.canGrantedEffectSupportActiveSkill(env.player.mainSkill.triggeredBy.gemData.grantedEffect, skill) and skill ~= env.player.mainSkill and (match1 or match2) and not isTriggered(skill) then
source, trigRate = findTriggerSkill(env, skill, source, trigRate)
local slotMatch = slotMatch(env, skill)
if not source then
local canSupport = env.player.mainSkill.triggeredBy.gemData and calcLib.canGrantedEffectSupportActiveSkill(env.player.mainSkill.triggeredBy.gemData.grantedEffect, skill)
if skill.skillData.triggerTime and canSupport and skill ~= env.player.mainSkill and slotMatch and not isTriggered(skill) then
source = skill
end
end
if skill.skillData.triggeredWhileChannelling and (match1 or match2) then
if skill.skillData.triggeredWhileChannelling and slotMatch then
t_insert(triggeredSkills, packageSkillDataForSimulation(skill, env))
end
end
Expand Down
Loading