Nissan: FW query tweaks for 2023 Nissan Altima

[royjr]

Nissan Altima 2023
Nissan B
1414bd4bad5acc8f/00000007--2e04252f32

[github-actions]

Car behavior report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

Testing 50 segments for: NISSAN_XTRAIL, NISSAN_LEAF, NISSAN_LEAF_IC, NISSAN_ROGUE, NISSAN_ALTIMA

✅ 0 changed, 50 passed, 0 errors

[jyoung8607]

@sshane This looks correct to me, insofar as it matches the data we're able to get back to the car, but I'm not sure how this was working for other Nissan without the change. There's a MY 2022 facelift of the existing 6th gen cars we support, but allegedly we already support a MY2024, so I'm not sure if the behavior change is related.

This PR seems fine to me, but I have no way to validate the change against other Nissan in bulk.

[sshane]

All the Nissan variants responded slightly differently to requests afaik. This only adds a request, probably fine but letr me check it out

[sshane]

1 is w/ OBD port, we want to only FP at camera commaai/openpilot#31243

[sshane]

related PRs

commaai/openpilot#31138
commaai/openpilot#28634
commaai/openpilot#29477

[sshane]

@royjr can you have user try this? very strange nothing returns without comma power on bus 0 since all the other Nissans work. Is this the normal harness setup?

sendcan: rxaddr=1858, bus=0,   1936 ms, 0x023e000000000000, b'\x02>\x00\x00\x00\x00\x00\x00', len(can.dat)=8
sendcan: rxaddr=1858, bus=1,   1936 ms, 0x023e000000000000, b'\x02>\x00\x00\x00\x00\x00\x00', len(can.dat)=8

    can: rxaddr=1858, bus=128, 1946 ms, 0x023e000000000000, b'\x02>\x00\x00\x00\x00\x00\x00', len(can.dat)=8
    can: rxaddr=1858, bus=2,   1946 ms, 0x023e000000000000, b'\x02>\x00\x00\x00\x00\x00\x00', len(can.dat)=8

    can: rxaddr=1858, bus=129, 1957 ms, 0x023e000000000000, b'\x02>\x00\x00\x00\x00\x00\x00', len(can.dat)=8
    can: rxaddr=1890, bus=1,   1957 ms, 0x037f3e1200000000, b'\x03\x7f>\x12\x00\x00\x00\x00', len(can.dat)=8

sendcan: rxaddr=1858, bus=0,   2483 ms, 0x0210810000000000, b'\x02\x10\x81\x00\x00\x00\x00\x00', len(can.dat)=8

    can: rxaddr=1858, bus=128, 2508 ms, 0x0210810000000000, b'\x02\x10\x81\x00\x00\x00\x00\x00', len(can.dat)=8
    can: rxaddr=1858, bus=2,   2508 ms, 0x0210810000000000, b'\x02\x10\x81\x00\x00\x00\x00\x00', len(can.dat)=8