feat(pgpm): add --minio flag to pgpm env for CDN/S3 environment variables#976
Merged
pyramation merged 1 commit intomainfrom Apr 11, 2026
Merged
feat(pgpm): add --minio flag to pgpm env for CDN/S3 environment variables#976pyramation merged 1 commit intomainfrom
pyramation merged 1 commit intomainfrom
Conversation
…bles - Add --minio flag that exports CDN_ENDPOINT, AWS_ACCESS_KEY, AWS_SECRET_KEY, AWS_REGION - Works alongside --supabase: pgpm env --supabase --minio - Fix arg parsing to use knownFlags filter instead of fragile index-based slicing - Update help text in env.ts and display.ts
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--minioflag topgpm envthat exports CDN/S3 environment variables (CDN_ENDPOINT,AWS_ACCESS_KEY,AWS_SECRET_KEY,AWS_REGION) alongside the existing PostgreSQL variables. This follows the same opt-in pattern as--supabase— Minio vars are only included when explicitly requested.Also fixes the arg-parsing logic: the old code used index-based slicing that only knew about
--supabase(everything before--supabasein arg position would be silently dropped). Replaced with aknownFlagsfilter that cleanly strips recognized flags regardless of position, which also makes it trivial to add future flags.Context: follows PR #975 which added
--include miniotopgpm docker. This gives users a matching way to get the env vars those containers need.Review & Testing Checklist for Human
CDN_ENDPOINTbutCLAUDE.mdreferencesMINIO_ENDPOINTfor S3/MinIO tests. ConfirmCDN_ENDPOINTis correct for the app's upload/streaming packages, or if it should beMINIO_ENDPOINT(or both)AWS_ACCESS_KEYvsAWS_ACCESS_KEY_ID: Standard AWS SDK expectsAWS_ACCESS_KEY_ID— confirm the codebase usesAWS_ACCESS_KEY(the non-standard name) everywherepgpm env --minio,pgpm env --supabase --minio,pgpm env --minio pgpm deploy --database db1and verify the correct exports are printed and commands execute with the right envhttp://localhost:9000, credsminioadmin/minioadmin) should match whatpgpm docker start --include minioactually startsNotes
--miniovariants — a few--supabase-only examples were removed (the flag still works, just fewer examples shown).--supabaseappeared after positional command args (e.g.,pgpm env createdb --supabase), the old code would dropcreatedb. The new code preserves it. This is a bug fix.Link to Devin session: https://app.devin.ai/sessions/44eca4b3fe5a46aaaf5c4907f0a0b600
Requested by: @pyramation