feat(cues): per-fire send_at scheduling on POST /v1/cues/{id}/fire (parity port of cueapi/cueapi#618)#78
Merged
Conversation
…arity port of cueapi/cueapi#618) Re-port of closed [PR #45](#45) which was on a stale base ~8880 deletions behind main. Fresh against current main HEAD. Closes §13 / Phase 12.1.7 (cue side). Optional `send_at` timestamp on the fire body delays dispatch until the time elapses. ## Why this is small The dispatch loop in `worker/poller.py:dispatch_outbox` already gates on `DispatchOutbox.scheduled_at` (added in slice 3b for messages, just merged via PR #77 for messages send_at). This PR plumbs `send_at` from FireRequest through to `Execution.scheduled_for` and `DispatchOutbox.scheduled_at`. No poller changes required. ## What lands - **app/schemas/cue.py** — new `FireRequest` Pydantic model with optional `send_at: Optional[datetime]` field. - **app/routers/cues.py** — `fire_cue` endpoint accepts optional `body: Optional[FireRequest] = None`. Computes effective `scheduled_for` (future send_at → that timestamp; past or omitted → now). Sets `DispatchOutbox.scheduled_at` on the outbox row when scheduled. - **tests/test_fire_send_at.py** — 6 tests verbatim from private (5 active + 1 skipped). The skipped test relies on `payload_override` which is a separate parity port (cueapi/cueapi#589/#590 — not yet in cueapi-core); marked with a `@pytest.mark.skip` + reason pointer so it un-skips automatically when those ports land. ## Semantics (per private cueapi#618) - `send_at` omitted (or no body) → existing behavior: dispatch immediately, outbox.scheduled_at = NULL. - `send_at` in the future → execution.scheduled_for = send_at, outbox.scheduled_at = send_at, dispatcher gates until that time. - `send_at` in the past → forgiving fallback to "fire now". No error. Same shape as send_at omitted. Idempotent — caller doesn't have to worry about clock skew or being a few ms late. ## Tests 5 new tests pass (omitted, future-delays-dispatch, past-falls-back, invalid-timestamp-422, worker-transport-no-outbox). 1 skipped (composes-with-payload-override, depends on PR #589/#590 port). Full local suite: 834 passed + 18 xfailed (pre-existing) + 4 skipped (1 new, 3 pre-existing). Zero regressions. ## Re-port note Re-port of closed PR #45. Fresh against current main after PR #74 + #75 + #77 merged earlier in this session.
Parity checkThis PR modifies files tracked in
Please confirm one of the following in a reply or PR description update:
This is a soft check — it does not block merge. The goal is visibility, not friction. See HOSTED_ONLY.md for the open-core policy. |
Merged
6 tasks
mikemolinet
added a commit
that referenced
this pull request
May 11, 2026
…ed_at on list endpoint (#79) Re-port of closed [PR #48](#48) which was on a stale base ~8870 deletions behind main. Fresh against current main HEAD via direct patch from the old branch's commit (c05518c). Adds query-side enrichment to ``GET /v1/executions``: - ``worker_id=`` — filter to executions claimed by a specific worker (Execution.claimed_by_worker) - ``status__in=foo,bar,baz`` — comma-separated multi-status filter. Mutex with ``status=``; 400 conflicting_filters if both passed. - Response gains ``oldest_claimed_at`` — earliest ``claimed_at`` over the filtered set, or null when count=0. Unblocks dashboard/menubar "oldest pending: 5m" rendering without a follow-up query. ## Use cases - **Menubar pending counter**: fetch ``pending,delivering,retry_ready`` in one round trip (status__in), get total + oldest_claimed_at to render "3 in flight, oldest claimed 8m ago". - **Worker health dashboard**: filter by worker_id to scope to one worker's claims; see how stale their oldest claim is. ## Tests 3 new tests in TestListExecutions: - worker_id scoping + oldest_claimed_at value reflects earliest claimed_at over filtered set - status__in union + status/status__in mutex 400 - null oldest_claimed_at on empty filtered set 31/31 in test_execution_parity.py green. Full local suite: zero regressions. ## Re-port note Re-port of closed PR #48 (commit c05518c). Branch was ~8870 deletions behind main; fresh against current main after PR #74/#75/#76/#77/#78 merged earlier in this session. Patch applied cleanly from c05518c to current main — the patch only touches list_executions endpoint, which has remained additive (cueapi-core added outcome_state filter since the branch was cut; this PR is compatible).
7 tasks
mikemolinet
added a commit
that referenced
this pull request
May 11, 2026
…ueapi/cueapi#630) (#80) Re-port of closed [PR #47](#47) which was on a stale base ~8880 deletions behind main. Fresh against current main HEAD. Phase A of the Agent Directory productization. Eliminates the failure mode where agents had to remember 6+ fields per recipient AND had no way to discover the live roster. ## What lands - **GET /v1/agents/roster** — display-optimized snapshot for prompt- injection at session-boot. Distinct from the existing management surface (GET /v1/agents): - Always-full list (no pagination) - Drops opaque IDs / secrets / timestamps / tenancy metadata - Adds derived ``online``, ``last_seen_relative``, ``preferred_contact`` - Always excludes soft-deleted agents - Weak ETag + ``If-None-Match`` → 304 Not Modified for poll efficiency - ETag bucketed to 5-min windows so quiet periods produce stable hashes - ``Cache-Control: private, max-age=300`` matches derivation buckets - **Migration 031** (renumbered from private's 048) — adds ``agents.last_seen_at TIMESTAMPTZ NULL``. Nullable, no backfill. - **Hot-path hooks** write ``last_seen_at = now()``: - ``create_message`` — sender's agent (in same tx via touch_last_seen) - ``list_inbox`` — recipient's agent, on EVERY poll (via _bump_last_seen_stmt). Even when no queued messages exist, the poll proves activity. - **Online derivation** (server-computed in ``list_roster``): - within 5 min → ``online`` - within 30 min → ``away`` - older or NULL → ``offline`` - Caller override wins: PATCHed status=away/offline keeps that override regardless of recent activity ## Pure helpers (for unit-testability — pytest-cov + ASGI issue) - ``_build_roster_entry(agent, now)`` in agent_service.py: ORM Agent → (entry_dict, etag_part_string) - ``_compute_roster_etag(parts)`` in agent_service.py: list → weak ETag - ``_derive_online_state(now, last_seen_at, asserted_status)`` → (online_bool, derived_status) - ``_format_relative(now, last_seen_at)`` → "active now" / "5m ago" / ... - ``_bucketed_seen(last_seen_at)`` → string for ETag stability - ``_bump_last_seen_stmt(agent_id, now)`` in inbox_service.py: SQLAlchemy UPDATE statement - ``_etag_matches(if_none_match, server_etag)`` in agents router: conditional GET predicate ## Tests 27 new tests in tests/test_agent_roster.py (verbatim from private): shape verification, hot-path hooks (sender + recipient), derivation correctness across all 3 buckets, caller-asserted status override, soft-delete exclusion, preferred_contact derivation, last_seen_relative formatting, ETag 304 handling, ETag changes when roster mutates, pure-helper unit tests. 27/27 pass locally. Full local suite: 890 passed + 18 xfailed (pre-existing) + 4 skipped. Zero regressions. ## Re-port note Re-port of closed PR #47. Fresh against current main after PR #74 + #75 + #76 + #77 + #78 + #79 merged earlier in this session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-port of closed PR #45 which was on a stale base ~8880 deletions behind main. Fresh against current main HEAD.
Closes §13 / Phase 12.1.7 (cue side). Optional
send_attimestamp on the fire body delays dispatch until the time elapses.Why this is small
The dispatch loop in
worker/poller.py:dispatch_outboxalready gates onDispatchOutbox.scheduled_at. This PR plumbssend_atfrom FireRequest through toExecution.scheduled_forandDispatchOutbox.scheduled_at. No poller changes required.What lands
app/schemas/cue.py— newFireRequestPydantic model with optionalsend_at: Optional[datetime].app/routers/cues.py—fire_cueaccepts optional body. Computes effectivescheduled_for(future send_at → that timestamp; past or omitted → now). SetsDispatchOutbox.scheduled_atwhen scheduled.tests/test_fire_send_at.py— 6 tests verbatim from private (5 active + 1 skipped). The skipped test relies onpayload_overridewhich is a separate port (cueapi/cueapi#589/#590); marked with@pytest.mark.skip+ reason pointer.Semantics (per private cueapi#618)
send_atomitted → dispatch immediately,outbox.scheduled_at = NULLsend_atfuture →execution.scheduled_for = send_at,outbox.scheduled_at = send_at, dispatcher gates until timesend_atpast → forgiving fallback to "fire now" (no error)Tests
5 new tests pass (omitted, future-delays-dispatch, past-falls-back, invalid-timestamp-422, worker-transport-no-outbox). 1 skipped (composes-with-payload-override, depends on PR #589/#590).
Full local suite: 834 passed + 18 xfailed (pre-existing) + 4 skipped. Zero regressions.
Wire format
send_atflows in the body ofPOST /v1/cues/{id}/fire. Body itself is optional — calling fire without a body still works as before.Sibling ports
fire --send-at(shipped earlier session)cueapi_fire_cue.send_at(shipped earlier session)fire send-atinput (shipped earlier session)client.cues.fire(..., send_at=...)(shipped earlier session)This is the cueapi-core (OSS server) side that was still missing.
Re-port note
Re-port of closed PR #45. Fresh against current main after PR #74 + #75 + #77 merged earlier in this session.
Test plan
🤖 Generated with Claude Code