feat(expert): allow setting file log level via configuration#563
Merged
doorgan merged 2 commits intoelixir-lang:mainfrom Apr 10, 2026
Merged
feat(expert): allow setting file log level via configuration#563doorgan merged 2 commits intoelixir-lang:mainfrom
doorgan merged 2 commits intoelixir-lang:mainfrom
Conversation
This is separated from LSP logging configuration. It defines the log level for expert.log file via workspace configuration.
This was referenced Apr 9, 2026
doorgan
approved these changes
Apr 9, 2026
Collaborator
doorgan
left a comment
doorgan
left a comment
There was a problem hiding this comment.
We should also update https://github.com/elixir-lang/expert/blob/main/pages/configuration.md
Contributor
Author
|
Right. Updated. |
doorgan
pushed a commit
to expert-lsp/vscode-expert
that referenced
this pull request
Apr 10, 2026
A companion to elixir-lang/expert#563 - allows setting `fileLogLevel` setting, which affects what is logged into `expert.log`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is separated from LSP logging configuration. It defines the log level for expert.log file via workspace configuration under key
fileLogLevel. It only affectsexpert.login this PR.project.logis handled by Engine, so it can be done as a followup (at the same time, the default level forproject.logisinfo, notdebug, so it's not so dire asexpert.login terms of growing file size.Sending explicit
nullasfileLogLevelresets it to default value (debug).Addresses #541