fix: sd-server uses lora_model_dir correctly#1328
Closed
mostlygeek wants to merge 4 commits intoleejet:masterfrom
Closed
fix: sd-server uses lora_model_dir correctly#1328mostlygeek wants to merge 4 commits intoleejet:masterfrom
mostlygeek wants to merge 4 commits intoleejet:masterfrom
Conversation
Pass ctx_params.lora_model_dir instead of "" for /v1/images/generations and /v1/images/edits handlers. The empty string caused extract_and_remove_lora() to return immediately.
|
This is a subset of #1156 but without the path sensitization. |
Reject absolute paths in user-supplied lora references and validate that resolved relative paths stay within lora_model_dir using fs::canonical(). This prevents path traversal attacks like <lora:../../etc/passwd:1> or <lora:/etc/shadow:1> from reading arbitrary files on the host. https://claude.ai/code/session_01RnNL2d3tAHW4pNuBDu3wi8
Owner
|
Closing this PR since it duplicates #1156 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass ctx_params.lora_model_dir instead of "" for /v1/images/generations and /v1/images/edits handlers. The empty string caused extract_and_remove_lora() to return immediately.
Tested this locally and the DEBUG output now correctly has the lora
Whereas current
masterthe loras would be an empty object.