Skip to content

fix: sd-server uses lora_model_dir correctly #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mostlygeek wants to merge 4 commits into from
+25 −7
Closed

fix: sd-server uses lora_model_dir correctly #1328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6ddf18
fix: sd-server uses lora_model_dir correctly
mostlygeek Mar 7, 2026
013ff99
Merge branch 'leejet:master' into master
mostlygeek Mar 11, 2026
2fee456
fix: sanitize lora paths to prevent directory traversal
claude Mar 15, 2026
a63c5c3
Merge pull request #1 from mostlygeek/claude/fix-lora-path-security-m…
mostlygeek Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions examples/common/common.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1657,12 +1657,18 @@ struct SDGenerationParams {
is_high_noise = true;
}

fs::path final_path;
// Security: reject absolute paths from user input to prevent
// arbitrary file access.
if (is_absolute_path(raw_path)) {
final_path = raw_path;
} else {
final_path = fs::path(lora_model_dir) / raw_path;
LOG_WARN("lora path must be relative: %s", raw_path.c_str());
tmp = m.suffix().str();
prompt = std::regex_replace(prompt, re, "", std::regex_constants::format_first_only);
continue;
}

// Resolve relative to the configured lora directory.
fs::path final_path = fs::path(lora_model_dir) / raw_path;

if (!fs::exists(final_path)) {
bool found = false;
for (const auto& ext : valid_ext) {
Expand All @@ -1682,7 +1688,19 @@ struct SDGenerationParams {
}
}

const std::string key = final_path.lexically_normal().string();
// Security: ensure the resolved path is within lora_model_dir
// to prevent path traversal (e.g. "../../etc/passwd").
const fs::path canon_dir = fs::canonical(lora_model_dir);
const fs::path canon_path = fs::canonical(final_path);
const std::string dir_str = canon_dir.string() + std::string(1, fs::path::preferred_separator);
if (canon_path.string().rfind(dir_str, 0) != 0 && canon_path != canon_dir) {
LOG_WARN("lora path escapes lora_model_dir: %s", raw_path.c_str());
tmp = m.suffix().str();
prompt = std::regex_replace(prompt, re, "", std::regex_constants::format_first_only);
continue;
}

const std::string key = canon_path.string();

if (is_high_noise)
high_noise_lora_map[key] += mul;
Expand Down
4 changes: 2 additions & 2 deletions examples/server/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ int main(int argc, const char** argv) {
if (gen_params.sample_params.sample_steps > 100)
gen_params.sample_params.sample_steps = 100;

if (!gen_params.process_and_check(IMG_GEN, "")) {
if (!gen_params.process_and_check(IMG_GEN, ctx_params.lora_model_dir)) {
res.status = 400;
res.set_content(R"({"error":"invalid params"})", "application/json");
return;
Expand Down Expand Up @@ -663,7 +663,7 @@ int main(int argc, const char** argv) {
if (gen_params.sample_params.sample_steps > 100)
gen_params.sample_params.sample_steps = 100;

if (!gen_params.process_and_check(IMG_GEN, "")) {
if (!gen_params.process_and_check(IMG_GEN, ctx_params.lora_model_dir)) {
res.status = 400;
res.set_content(R"({"error":"invalid params"})", "application/json");
return;
Expand Down