docs: replace deprecated PingCAP domains#22687
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| upload_to_qiniu(local_file, remote_name) | ||
|
|
||
| print("https://download.pingcap.org/{}".format(remote_name)) | ||
| print("https://download.pingcap.com/{}".format(remote_name)) |
There was a problem hiding this comment.
To improve maintainability, it's better to define this hardcoded URL format string as a constant. This makes it easier to manage if the URL needs to be changed again in the future.
For example, you could add DOWNLOAD_URL_FORMAT = "https://download.pingcap.com/{}" near the other constants at the top of the file, and then change this line to:
print(DOWNLOAD_URL_FORMAT.format(remote_name))
Summary
download.pingcap.orgreferences withdownload.pingcap.comcharts.pingcap.orgreferences withcharts.pingcap.comValidation
git diff --checkdownload.pingcap.org/charts.pingcap.orgreferences in the patched branch