Skip to content

docs: replace deprecated PingCAP domains #22687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wuhuizuo wants to merge 1 commit into
base: release-7.1
Choose a base branch
from
Open

docs: replace deprecated PingCAP domains #22687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,4 @@ def upload_to_aws(local_file, remote_name=None):
#upload_to_aws(local_file, remote_name)
upload_to_qiniu(local_file, remote_name)

print("https://download.pingcap.org/{}".format(remote_name))
print("https://download.pingcap.com/{}".format(remote_name))
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

To improve maintainability, it's better to define this hardcoded URL format string as a constant. This makes it easier to manage if the URL needs to be changed again in the future.

For example, you could add DOWNLOAD_URL_FORMAT = "https://download.pingcap.com/{}" near the other constants at the top of the file, and then change this line to:

print(DOWNLOAD_URL_FORMAT.format(remote_name))

Loading